Bug 1493969

Summary: stonith configuration is currently broken
Product: Red Hat OpenStack Reporter: Michele Baldessari <michele>
Component: puppet-pacemakerAssignee: Michele Baldessari <michele>
Status: CLOSED ERRATA QA Contact: nlevinki <nlevinki>
Severity: high Docs Contact:
Priority: high    
Version: 12.0 (Pike)CC: chjones, jjoyce, jschluet, mkrcmari, slinaber, tvignaud
Target Milestone: betaKeywords: Triaged
Target Release: 12.0 (Pike)   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: puppet-pacemaker-0.6.1-0.20171015172907.44d3226.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1509912 (view as bug list) Environment:
Last Closed: 2017-12-13 22:11:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1509912, 1536067    

Description Michele Baldessari 2017-09-21 08:53:40 UTC 
There are currently two problems when we configure stonith via tripleo.

A) https://bugs.launchpad.net/tripleo/+bug/1717531
parameter_defaults:
  EnableFencing: true
  FencingConfig:
    devices:
    - agent: fence_ipmilan
      host_mac: 00:92:bb:63:40:3d
      params:
        login: admin
        ipaddr: 192.168.24.1
        ipport: 6230
        passwd: password
        lanplus: 1
....

The deploy did not have stonith enabled:
Cluster Properties:
 cluster-infrastructure: corosync
 cluster-name: tripleo_cluster
 dc-version: 1.1.16-12.13.el7.centos-94ff4df
 have-watchdog: false
 redis_REPL_INFO: overcloud-controller-0
 stonith-enabled: false

B) https://bugs.launchpad.net/tripleo/+bug/1717566
Stonith creation is racy and not all stonith resources get created.


So the following might happen:
Sep 15 09:43:51 localhost os-collect-config: "Notice: /Stage[main]/Tripleo::Fencing/Pacemaker::Stonith::Fence_ipmilan[00:92:bb:63:40:9f]/Exec[Create stonith-fence_ipmilan-0092bb63409f]/returns: executed successfully",
Sep 15 09:43:51 localhost os-collect-config: "Notice: /Stage[main]/Tripleo::Fencing/Pacemaker::Stonith::Fence_ipmilan[00:92:bb:63:40:9f]/Exec[Add non-local constraint for stonith-fence_ipmilan-0092bb63409f]/returns: Error: Resource 'stonith-fence_ipmilan-0092bb63409f' does not exist"

The reasons for this are the direct calls to the pcs command.
Comment 1 Michele Baldessari 2017-09-21 09:03:17 UTC 
Reviews linked:
A) https://bugs.launchpad.net/tripleo/+bug/1717531
https://review.openstack.org/504425

B) https://bugs.launchpad.net/tripleo/+bug/1717566
https://review.openstack.org/504931
https://review.openstack.org/504932
Comment 2 Michele Baldessari 2017-09-21 18:55:18 UTC 
One more smaller patch is needed. gerrit @ openstack is down. will link here the review once it is up
Comment 3 Michele Baldessari 2017-09-21 19:08:30 UTC 
Ok added last review. While this one (506326) is not essential for tripleo, it'd still be good to have
Comment 4 Michele Baldessari 2017-09-22 14:40:19 UTC 
506326 merged, moving to POST again
Comment 9 errata-xmlrpc 2017-12-13 22:11:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:3462