Bug 1493996

Summary: [RFE ] OpenStack: Handle dialog fields when provisioning using Heat Orchestration.
Product: Red Hat CloudForms Management Engine Reporter: Sachin <sacpatil>
Component: AutomateAssignee: Greg McCullough <gmccullo>
Status: CLOSED ERRATA QA Contact: Omri Hochman <ohochman>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: dajohnso, gmccullo, jhardy, lkhomenk, mkanoor, myoder, obarenbo, sacpatil, simaishi, tfitzger
Target Milestone: GAKeywords: FutureFeature, Reopened
Target Release: 5.9.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.9.0.5 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-01 13:18:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Service dialogs none

Description Sachin 2017-09-21 09:53:25 UTC
Created attachment 1328884 [details]
Service dialogs

Description of problem:

Service Catalog Item Type: openstack

evm.logs
~~~
[----] I, [2017-09-21T05:19:25.171797 #7962:9a77fc]  INFO -- : Q-task_id([miq_provision_78000000000107]) <AEMethod openstack_postprovision> Provisioning options: {:initial_pass=>true, :service_template_request=>
false, :miq_request_dialog_name=>"miq_provision_openstack_dialogs_template", :customize_enabled=>["enabled"], :requester_enabled=>["disabled"], :purpose_enabled=>["disabled"], :current_tab_key=>:schedule, :owner
_phone=>nil, :owner_country=>nil, :owner_phone_mobile=>nil, :owner_title=>nil, :owner_first_name=>nil, :owner_manager=>nil, :owner_address=>nil, :owner_company=>nil, :owner_last_name=>nil, :owner_manager_mail=>n
il, :owner_city=>nil, :owner_department=>nil, :owner_load_ldap=>nil, :owner_manager_phone=>nil, :owner_state=>nil, :owner_office=>nil, :owner_zip=>nil, :owner_email=>nil, :request_notes=>nil, :vm_tags=>[], :plac
ement_auto=>[true, 1], :placement_availability_zone=>[nil, nil], :cloud_tenant=>[nil, nil], :cloud_network=>[78000000000009, "private"], :security_groups=>[nil, nil], :floating_ip_address=>[nil, nil], :number_of
_vms=>[1, "1"], :vm_description=>nil, :vm_prefix=>nil, :src_vm_id=>[78000000000009, "cirros"], :vm_name=>"changeme19", :schedule_type=>["immediately", "Immediately on Approval"], :schedule_time=>Tue, 05 Sep 2017
 00:00:00 UTC +00:00, :retirement=>[2592000, "1 Month"], :retirement_warn=>[604800, "1 Week"], :instance_type=>[78000000000006, "m1.tiny"], :guest_access_key_pair=>[78000000000011, "psachin-key"], :name=>"RHOSP-
11", :size=>nil, :delete_on_terminate=>false, :dns_servers=>nil, :dns_suffixes=>nil, :addr_mode=>["dhcp", "DHCP"], :linux_host_name=>"changeme19", :gateway=>nil, :linux_domain_name=>nil, :subnet_mask=>nil, :cust
omization_template_script=>nil, :root_password=>nil, :hostname=>nil, :start_date=>"9/5/2017", :start_hour=>"0", :start_min=>"0", :description=>"rhosp", :long_description=>"", :provision_cost=>nil, :display=>true
, :catalog_id=>78000000000001, :st_prov_type=>"openstack", :available_catalogs=>[["Ansible", 78000000000002], ["RHOSP", 78000000000001]], :retire_fqname=>"/Service/Retirement/StateMachines/ServiceRetirement/Defa
ult", :reconfigure_fqname=>"", :fqname=>"/Service/Provisioning/StateMachines/ServiceProvision_Template/CatalogItemInitialization", :available_dialogs=>{78000000000001=>"azure-single-vm-from-user-image", 78000000
000002=>"RHOSP", 78000000000003=>"OpenStack | Create External Network", 78000000000004=>"OpenStack | Create Instance"}, :service_type=>"atomic", :dialog_id=>78000000000002, :src_vm_nics=>[], :src_vm_lans=>[], :s
rc_ems_id=>[78000000000008, "osp11-4.gsslab.pnq2.redhat.com"], :volumes=>[], :requester_group=>"EvmGroup-super_administrator", :delivered_on=>nil, :customization_template_id=>[nil, nil], :pass=>0, :miq_force_uni
que_name=>[true, 1], :service_guid=>"50ce1b9a-9ead-11e7-adcd-525400d80b05", :service_resource_id=>78000000000030, :owner_group=>"EvmGroup-super_administrator", :dns_domain=>nil, :vm_target_name=>"changeme19", :v
m_target_hostname=>"changeme19", :dialog_vm_name=>"changeme19", :dest_availability_zone=>[nil, nil], :networks=>[{"net_id"=>"7d068b84-3186-4364-83fe-6baff5a7994b"}]}
~~~


Version-Release number of selected component (if applicable):
5.8.0.17

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

key is named as: Array::dialog_vm_tags

~~~
[----] I, [2017-09-21T05:15:04.935338 #7962:9a7d60]  INFO -- : Q-task_id([service_template_provision_task_78000000000105]) <AEMethod dialog_parser> dialog_options: {"dialog_vm_name"=>"changeme19", "Array::dialog
_vm_tags"=>"Classification::78000000000019", "request"=>"clone_to_service", :service_action=>"Provision", "Service::Service"=>78000000000063}
~~~

Comment 3 Dave Johnson 2017-09-21 10:45:01 UTC
Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set it to Low/Low.

Comment 8 Greg McCullough 2017-09-27 20:14:10 UTC
Based on the information in the description the customer is not using an orchestration template based on the reference to miq_provision_### and "<AEMethod openstack_postprovision>".

Has there been any feedback from the customer?

Comment 11 Greg McCullough 2017-10-02 18:49:15 UTC
This is not a feature implemented for orchestration which is what the customer is using.

They would need to add a post-provisioning step in their state machine to process the tag values coming from the dialog.

We can turn this into an RFE and look into adding this feature, but it was never part of the orchestration work.

Comment 14 CFME Bot 2017-10-27 20:42:01 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/195afd528720d24736bab448ee831cc8c4d57a3e

commit 195afd528720d24736bab448ee831cc8c4d57a3e
Author:     Greg McCullough <gmccullo>
AuthorDate: Tue Oct 24 17:06:26 2017 -0400
Commit:     Greg McCullough <gmccullo>
CommitDate: Fri Oct 27 15:38:31 2017 -0400

    Apply dialog tags to VMs created during orchestration provisioning
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1493996

 app/models/service_orchestration.rb                |  2 +
 .../service_orchestration/provision_tagging.rb     | 32 +++++++++
 .../provision_tagging_spec.rb                      | 83 ++++++++++++++++++++++
 spec/models/service_orchestration_spec.rb          |  2 +
 4 files changed, 119 insertions(+)
 create mode 100644 app/models/service_orchestration/provision_tagging.rb
 create mode 100644 spec/models/service_orchestration/provision_tagging_spec.rb

Comment 18 errata-xmlrpc 2018-03-01 13:18:06 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0380

Comment 19 Red Hat Bugzilla 2023-09-14 04:08:28 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days