Bug 1494357

Summary: containerized install failed when openshift_use_crio=true and openshift_release=v3.7 is set
Product: OpenShift Container Platform Reporter: Johnny Liu <jialiu>
Component: InstallerAssignee: Giuseppe Scrivano <gscrivan>
Status: CLOSED ERRATA QA Contact: Johnny Liu <jialiu>
Severity: medium Docs Contact:
Priority: high    
Version: 3.7.0CC: aos-bugs, gscrivan, jokerman, mmccomas, sdodson, smilner, wmeng
Target Milestone: ---Keywords: Reopened
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-28 22:12:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Johnny Liu 2017-09-22 06:27:21 UTC
Description of problem:
See the following details.

Version-Release number of the following components:
openshift-ansible-3.7.0-0.126.6.git.0.a60fe67.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. prepare inventory host file with openshift_use_crio=true and openshift_release=v3.7 setting
2. trigger installation
3.

Actual results:
Installation failed at the following task:
TASK [openshift_version : Set containerized version to configure if openshift_release specified] ***
Thursday 21 September 2017  08:42:03 +0000 (0:00:00.043)       0:02:40.729 **** 
ok: [ec2-54-226-84-221.compute-1.amazonaws.com] => {
    "ansible_facts": {
        "openshift_version": "3.7"
    }, 
    "changed": false, 
    "failed": false
}
<--snip-->
TASK [openshift_version : set_fact] ********************************************
Thursday 21 September 2017  08:42:15 +0000 (0:00:00.041)       0:02:52.956 **** 
ok: [ec2-54-226-84-221.compute-1.amazonaws.com] => {
    "ansible_facts": {
        "openshift_rpm_version": "3.7.0"
    }, 
    "changed": false, 
    "failed": false
}

TASK [openshift_version : Fail if rpm version and docker image version are different] ***
Thursday 21 September 2017  08:42:15 +0000 (0:00:00.060)       0:02:53.016 **** 
fatal: [ec2-54-226-84-221.compute-1.amazonaws.com]: FAILED! => {
    "changed": false, 
    "failed": true
}

MSG:

OCP rpm version 3.7.0 is different from OCP image version 3.7



Expected results:
Installation is completed successfully.

Additional info:
Try a containerized install with openshift_use_crio=true disabled, the above task is passed.

Go though openshift-ansible code, seem like the judgment in the following task have some problem, l_use_crio=true make this task is skipped, which cause openshift_version is set to a wrong version.
- name: Set precise containerized version to configure if openshift_release specified
  command: >
    docker run --rm {{ openshift.common.cli_image }}:v{{ openshift_version }} version
  register: cli_image_version
  when:
  - openshift_version is defined
  - openshift_version.split('.') | length == 2
  - not l_use_crio

Comment 2 Giuseppe Scrivano 2017-09-25 07:20:11 UTC
this problem is being addressed by:

https://github.com/openshift/openshift-ansible/pull/5490

Comment 3 Johnny Liu 2017-10-09 02:37:34 UTC
refer to https://bugzilla.redhat.com/show_bug.cgi?id=1493376#c6

Comment 4 Steve Milner 2017-10-09 13:36:19 UTC
Should this be marked a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1493376#c6? Or fixes for both bugs in the one PR?

Comment 5 Giuseppe Scrivano 2017-10-09 13:46:19 UTC
@Steve, yes, let's close this as a duplicate since it is the same root cause.

*** This bug has been marked as a duplicate of bug 1493376 ***

Comment 6 Johnny Liu 2017-10-10 06:01:59 UTC
I do not think this is a dup of bug 1493376, but the fix PR connect the two bugs together. 

I will move this bug to ON_QA, once the fix PR for bug 1493376 is merged, will verify them together.

Comment 7 Johnny Liu 2017-10-13 10:10:41 UTC
Verified this bug with openshift-ansible-3.7.0-0.148.0.git.0.b35eb14.el7.noarch, and PASS.

"openshift_version : Fail if rpm version and docker image version are different" task is passed.

Comment 11 errata-xmlrpc 2017-11-28 22:12:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188