Bug 1494400
Summary: | Run virsh domxml-to-native successfully with extra param | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | lcheng |
Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
Status: | CLOSED ERRATA | QA Contact: | Meina Li <meili> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 7.5 | CC: | dyuan, fjin, junli, pkrempa, rbalakri, xuzhang, yisun |
Target Milestone: | rc | Keywords: | Automation, Regression |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | libvirt-3.9.0-1.el7 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-04-10 10:57:19 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
lcheng
2017-09-22 08:02:28 UTC
Fixed upstream: commit f4973d1ea88b2e807fc2c52a5fc281a1c289d50e Author: Peter Krempa <pkrempa> Date: Tue Oct 10 17:19:10 2017 +0200 virsh: domain: Fix option handling in domxml-to-native Commit fdeac7a05fdf85458d72e89efcfa0f444525aaad tried to fix the output of 'virsh domxml-to-native --help' by switching types around. One of the changes broke the option parser. VSH_OT_ARGV should be used only for variable argument count, not to make the help generator look pretty. The correct option type in this case is VSH_OT_STRING as it's not mandatory now since it can be substituted by using --domain. This makes --help for this command look incorrect, but the parser works as it should. Verified on: libvirt-3.9.0-1.el7.x86_64 qemu-kvm-rhev-2.10.0-4.el7.x86_64 Steps to verify: 1. Using --xml option with extra param: # virsh dumpxml lmn >lmn.xml # virsh domxml-to-native qemu-argv --xml lmn.xml 12as error: unexpected data '12as' 2. Using --domain option with extra param: # virsh domxml-to-native qemu-argv --domain lmn 12as error: Options --domain and --xml are mutually exclusive For the step 2, the extra parameter isn't a domain XML config, but libvirt check it as a xml, is it expected? Yes, that is due to the fact that --xml was an implicit argument and thus it's automatically covered by the first argument without an explicit flag. According to the test result and explanations,move this bug to VERIFIED. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2018:0704 |