Bug 1494420

Summary:	sos doesn't support PostgreSQL95 from Software Collections
Product:	Red Hat Enterprise Linux 7	Reporter:	Sandro Bonazzola <sbonazzo>
Component:	sos	Assignee:	Pavel Moravec <pmoravec>
Status:	CLOSED ERRATA	QA Contact:	Lukas Svaty <lsvaty>
Severity:	urgent	Docs Contact:
Priority:	high
Version:	7.4	CC:	agk, bmr, dnecpal, dougsland, gavin, lsvaty, mhradile, mkalinin, plambri, pmoravec, sbonazzo, sbradley, toneata, ylavi
Target Milestone:	rc	Keywords:	ZStream
Target Release:	7.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sos-3.5-3.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1515113 (view as bug list)		Environment:
Last Closed:	2018-04-10 18:05:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1494419, 1513071, 1515113

Description Sandro Bonazzola 2017-09-22 08:49:50 UTC

Description of problem:
In RHV 4.2 we are now moving to PostgreSQL95 from software collections.
sos postresql plugin doesn't work with software collections.
Issue reported upstream: https://github.com/sosreport/sos/issues/1090

Comment 1 Pavel Moravec 2017-09-22 10:11:06 UTC

Technical specification what change is required is completely missing (here and also in the upstream issue). Also relationship to sos PR 900 is unclear.

Please react in https://github.com/sosreport/sos/issues/1090#issuecomment-331407466 to let me understand what are the requirements.

(hint: if you would follow the default BZ template and fill "Steps to Reproduce:", "Actual results:" and "Expected results:", we would know much more)

Comment 2 Oneata Mircea Teodor 2017-09-22 10:14:23 UTC

Please refer to zstream documentation when creating bugs for cloning, rhel 7.5 flag added.
https://mojo.redhat.com/docs/DOC-1021938#jive_content_id_Executive_Summary

Comment 3 Pavel Moravec 2017-11-02 15:15:19 UTC

Fixed via sos 3.5 rebase.

Comment 9 Pavel Moravec 2017-11-19 17:21:33 UTC

Due to the late phase and our QE capacity constrains, could Sandro or somebody else from RHEV team verify the z-stream BZ (I doubt sos QE will have capacity for it and I wont commit anything to 7.4.z until I have *some* qa_ack)?

Comment 11 Sandro Bonazzola 2017-11-30 09:32:07 UTC

(In reply to Pavel Moravec from comment #9)
> Due to the late phase and our QE capacity constrains, could Sandro or
> somebody else from RHEV team verify the z-stream BZ (I doubt sos QE will
> have capacity for it and I wont commit anything to 7.4.z until I have *some*
> qa_ack)?

Lukas?

Comment 12 David Necpal 2017-11-30 10:24:49 UTC

Hi Sandro, can you provide verification steps please?

Using 
sos-3.5-1.el7.noarch
ovirt-log-collector-4.2.1-0.0.master.20171129193044.git105bbe9.el7.centos.noarch

I encountred the same issue:

/tmp/sosreport-LogCollector-20171130115825/log-collector-data/sosreport-example.com-20171130115825/sos_logs:

2017-11-30 11:58:25,365 INFO: [archive:TarFileArchive] initialised empty FileCacheArchive at '/tmp/logcollector-pWgn45/working/log-collector-data/sos.VfKUEb/sosreport-example.com-20171130115825'
2017-11-30 11:58:25,366 INFO: [sos.sosreport:setup] executing 'sosreport --batch -o postgresql --tmp-dir=/tmp/logcollector-pWgn45/working/log-collector-data -k postgresql.dbname=engine -k postgresql.dbhost=localhost -k postgresql.dbport=5432 -k postgresql.username=engine'

*******************
2017-11-30 11:58:25,375 INFO: [plugin:postgresql] Unable to execute pg_dump. Error()
2017-11-30 11:58:25,475 INFO: [plugin:postgresql] Unable to execute pg_dump. Error()
*******************
2017-11-30 11:58:25,476 INFO: [plugin:postgresql] collecting path '/var/lib/pgsql/initdb_rh-postgresql95-postgresql.log'
2017-11-30 11:58:25,477 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Tue.log'
2017-11-30 11:58:25,479 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/PG_VERSION'
2017-11-30 11:58:25,480 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Thu.log'
2017-11-30 11:58:25,481 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Sat.log'
2017-11-30 11:58:25,482 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.conf'
2017-11-30 11:58:25,483 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_ident.conf'
2017-11-30 11:58:25,484 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_hba.conf'
2017-11-30 11:58:25,484 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Fri.log'
2017-11-30 11:58:25,485 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Wed.log'
2017-11-30 11:58:25,486 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postmaster.opts'
2017-11-30 11:58:25,487 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.auto.conf'
2017-11-30 11:58:25,488 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Mon.log'
2017-11-30 11:58:25,488 INFO: [plugin:postgresql] collecting path '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Sun.log'

Comment 13 Douglas Schilling Landgraf 2017-11-30 20:15:17 UTC

(In reply to David Necpal from comment #12)
> Hi Sandro, can you provide verification steps please?
> 
> Using 
> sos-3.5-1.el7.noarch
> ovirt-log-collector-4.2.1-0.0.master.20171129193044.git105bbe9.el7.centos.
> noarch
> 
> I encountred the same issue:
> 

It's not fixed in sos-3-5-1.  Pavel might know the right rpm to test.

> /tmp/sosreport-LogCollector-20171130115825/log-collector-data/sosreport-
> example.com-20171130115825/sos_logs:
> 
> 2017-11-30 11:58:25,365 INFO: [archive:TarFileArchive] initialised empty
> FileCacheArchive at
> '/tmp/logcollector-pWgn45/working/log-collector-data/sos.VfKUEb/sosreport-
> example.com-20171130115825'
> 2017-11-30 11:58:25,366 INFO: [sos.sosreport:setup] executing 'sosreport
> --batch -o postgresql
> --tmp-dir=/tmp/logcollector-pWgn45/working/log-collector-data -k
> postgresql.dbname=engine -k postgresql.dbhost=localhost -k
> postgresql.dbport=5432 -k postgresql.username=engine'
> 
> *******************
> 2017-11-30 11:58:25,375 INFO: [plugin:postgresql] Unable to execute pg_dump.
> Error()
> 2017-11-30 11:58:25,475 INFO: [plugin:postgresql] Unable to execute pg_dump.
> Error()
> *******************
> 2017-11-30 11:58:25,476 INFO: [plugin:postgresql] collecting path
> '/var/lib/pgsql/initdb_rh-postgresql95-postgresql.log'
> 2017-11-30 11:58:25,477 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Tue.log'
> 2017-11-30 11:58:25,479 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/PG_VERSION'
> 2017-11-30 11:58:25,480 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Thu.log'
> 2017-11-30 11:58:25,481 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Sat.log'
> 2017-11-30 11:58:25,482 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.conf'
> 2017-11-30 11:58:25,483 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_ident.conf'
> 2017-11-30 11:58:25,484 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_hba.conf'
> 2017-11-30 11:58:25,484 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Fri.log'
> 2017-11-30 11:58:25,485 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Wed.log'
> 2017-11-30 11:58:25,486 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postmaster.opts'
> 2017-11-30 11:58:25,487 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/postgresql.auto.conf'
> 2017-11-30 11:58:25,488 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Mon.log'
> 2017-11-30 11:58:25,488 INFO: [plugin:postgresql] collecting path
> '/var/opt/rh/rh-postgresql95/lib/pgsql/data/pg_log/postgresql-Sun.log'

Comment 14 Pavel Moravec 2017-11-30 21:48:08 UTC

(In reply to Douglas Schilling Landgraf from comment #13)
> (In reply to David Necpal from comment #12)
> > Hi Sandro, can you provide verification steps please?
> > 
> > Using 
> > sos-3.5-1.el7.noarch
> > ovirt-log-collector-4.2.1-0.0.master.20171129193044.git105bbe9.el7.centos.
> > noarch
> > 
> > I encountred the same issue:
> > 
> 
> It's not fixed in sos-3-5-1.  Pavel might know the right rpm to test.
> 

This isnt yet fully resolved due to:

bz1513071: Log Analyzer unable to detect sos_pgdump.tar

Most of the requirements in this BZ _are_ fixed (most of the data collected for non-SCL postgres are collected also for SCL-installed postgres), but it makes sense to defer verification a week when I should have a package respin incl. sos PR:

https://github.com/sosreport/sos/pull/1154

merged and backported.

I am changing the BZ status to make it explicit.

Let me know if description of particular verification steps are required.

Comment 18 Lukas Svaty 2018-01-19 17:10:33 UTC

verified with 
sos-3.5-4.el7.noarch
rh-postgresql95-postgresql-9.5.9-1.el7.x86_64
Red Hat Enterprise Linux Server release 7.5 Beta (Maipo) Build: RHEL-7.5-20171130.0

Comment 22 errata-xmlrpc 2018-04-10 18:05:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0963