Bug 1494525

Summary: Can attach OVF-STORE as disk while creating a new VM
Product: [oVirt] ovirt-engine Reporter: Sandro Bonazzola <sbonazzo>
Component: BLL.StorageAssignee: Tal Nisan <tnisan>
Status: CLOSED CURRENTRELEASE QA Contact: Yosi Ben Shimon <ybenshim>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: amureini, bugs, lveyde, tnisan
Target Milestone: ovirt-4.2.1Flags: rule-engine: ovirt-4.2+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-engine-4.2.1.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-02-12 11:48:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
image selection dialog
none
image attached
none
images list
none
direct LUN none

Description Sandro Bonazzola 2017-09-22 12:23:15 UTC 
Description of problem:
Can attach OVF-STORE as disk while creating a new VM

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170920172148.git8366a0b.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. try to create a vm
2. try to attach a disk

Actual results:
you'll see OVF-STORE as images that can be attached to the VM

Expected results:
you shouldn't be able to attach OVF-STORE as disk to VMs

Attaching screenshot
Comment 1 Sandro Bonazzola 2017-09-22 12:25:46 UTC 
Created attachment 1329562 [details]
image selection dialog
Comment 2 Sandro Bonazzola 2017-09-22 12:26:14 UTC 
Created attachment 1329564 [details]
image attached
Comment 3 Allon Mureinik 2017-09-24 14:41:16 UTC 
I believe this is intentional.
Tal?
Comment 4 Tal Nisan 2017-09-25 09:16:31 UTC 
This was always the behavior, the disks list was not filtered when trying to attach to a VM, however the operation did and is still failing with "Cannot attach Virtual Disk. The operation is not supported for OVF_STORE disks."
Having said that, after the latest changing regarding content type it now makes it easier to filter out disks that cannot be attached to a VM, Allon do you think that this is worth the effort?
Comment 5 Allon Mureinik 2017-09-25 10:59:57 UTC 
(In reply to Tal Nisan from comment #4)
> This was always the behavior, the disks list was not filtered when trying to
> attach to a VM, however the operation did and is still failing with "Cannot
> attach Virtual Disk. The operation is not supported for OVF_STORE disks."
Removing the Regression keyword based on that.

> Having said that, after the latest changing regarding content type it now
> makes it easier to filter out disks that cannot be attached to a VM, Allon
> do you think that this is worth the effort?
If it's an easy win, let's do it.
Comment 6 Yosi Ben Shimon 2018-01-15 09:29:34 UTC 
Tested on ovirt-engine-4.2.1.1-0.1.el7.noarch and the disks list is filtered and no OVF_STORE disks appear in the list.
See attached screen shots.

Moving to VERIFIED
Comment 7 Yosi Ben Shimon 2018-01-15 09:30:37 UTC 
Created attachment 1381313 [details]
images list
Comment 8 Yosi Ben Shimon 2018-01-15 09:31:00 UTC 
Created attachment 1381314 [details]
direct LUN
Comment 9 Yosi Ben Shimon 2018-01-15 09:36:42 UTC 
Forgot to mention that it was checked in both scenarios:
1. During the creation of the VM.
2. After VM creation:
 - Click on the VM name to open it's properties.
 - Under "disks" tab -> "attach" button on the top right
Comment 10 Sandro Bonazzola 2018-02-12 11:48:02 UTC 
This bugzilla is included in oVirt 4.2.1 release, published on Feb 12th 2018.

Since the problem described in this bug report should be
resolved in oVirt 4.2.1 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.