Bug 1494979

Created attachment 1348792 [details]
updated specfile

Updated spec file according to review comments:

Spec URL: https://raw.githubusercontent.com/omeranson/jsonmodels/rpm-spec/rpm/python-jsonmodels.spec

SRPM URL: https://github.com/omeranson/jsonmodels/raw/rpm-spec/rpm/python-jsonmodels-2.2-1.src.rpm

Description: 

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.

For more examples and better description see full documentation: http://jsonmodels.rtfd.org.

Fedora Account System Username: oanson

Review comments that were addressed:
* Make description smaller. No longer than a few lines.
* Remove Group tag
* Remove BuildRoot
* Remove Prefix
* Remove Vendor
* Create %use_tests macro, and set it true iff fedora and add comment
* Remove %defattr
* Verify with rpmlint
* Verify links with spec-tool -g
* rename specfile to python-jsonmodels.spec
* Rename source0 to jsonmodels-2.2.tar.gz.
* Remove 'version' and 'unmangled_version' macros. Set 'Version' and use that (it's also a macro definition)
* Add changelog

Updating the links:

Spec URL: https://raw.githubusercontent.com/omeranson/jsonmodels/rpm-spec/rpm/python-jsonmodels.spec

SRPM URL: https://github.com/omeranson/jsonmodels/raw/rpm-spec/rpm/python-jsonmodels-2.2-1.fc27.src.rpm

Informal reviews:
https://bugzilla.redhat.com/show_bug.cgi?id=1513175
https://bugzilla.redhat.com/show_bug.cgi?id=1513167
https://bugzilla.redhat.com/show_bug.cgi?id=1513173
https://bugzilla.redhat.com/show_bug.cgi?id=1513169
https://bugzilla.redhat.com/show_bug.cgi?id=1513152
https://bugzilla.redhat.com/show_bug.cgi?id=1513163

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (3 clause)", "Unknown or generated". 69 files have unknown
     license. Detailed output of licensecheck in
     /home/mrunge/review/1494979-python-jsonmodels/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -python-jsonmodels , python3-python-jsonmodels
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-python-jsonmodels-2.2-1.fc28.noarch.rpm
          python3-python-jsonmodels-2.2-1.fc28.noarch.rpm
          python-jsonmodels-2.2-1.fc28.src.rpm
python2-python-jsonmodels.noarch: W: summary-ended-with-dot C Models to make easier to deal with structures that are converted to, or read from JSON.
python2-python-jsonmodels.noarch: E: summary-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python2-python-jsonmodels.noarch: E: description-line-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python3-python-jsonmodels.noarch: W: summary-ended-with-dot C Models to make easier to deal with structures that are converted to, or read from JSON.
python3-python-jsonmodels.noarch: E: summary-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python3-python-jsonmodels.noarch: E: description-line-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
3 packages and 0 specfiles checked; 4 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
python2-python-jsonmodels.noarch: W: summary-ended-with-dot C Models to make easier to deal with structures that are converted to, or read from JSON.
python2-python-jsonmodels.noarch: E: summary-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python2-python-jsonmodels.noarch: E: description-line-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python2-python-jsonmodels.noarch: W: invalid-url URL: https://github.com/beregond/jsonmodels <urlopen error [Errno -2] Name or service not known>
python3-python-jsonmodels.noarch: W: summary-ended-with-dot C Models to make easier to deal with structures that are converted to, or read from JSON.
python3-python-jsonmodels.noarch: E: summary-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python3-python-jsonmodels.noarch: E: description-line-too-long C Models to make easier to deal with structures that are converted to, or read from JSON.
python3-python-jsonmodels.noarch: W: invalid-url URL: https://github.com/beregond/jsonmodels <urlopen error [Errno -2] Name or service not known>
2 packages and 0 specfiles checked; 4 errors, 4 warnings.



Requires
--------
python2-python-jsonmodels (rpmlib, GLIBC filtered):
    python(abi)
    python-dateutil
    python-six

python3-python-jsonmodels (rpmlib, GLIBC filtered):
    python(abi)
    python3-dateutil
    python3-six



Provides
--------
python2-python-jsonmodels:
    python2-python-jsonmodels
    python2.7dist(jsonmodels)
    python2dist(jsonmodels)

python3-python-jsonmodels:
    python3-python-jsonmodels
    python3.6dist(jsonmodels)
    python3dist(jsonmodels)



Source checksums
----------------
https://github.com/beregond/jsonmodels/archive/2.2.tar.gz#/python-jsonmodels-2.2.tar.gz :
  CHECKSUM(SHA256) this package     : 0318e4256539b6830aaea284dc5dc336b970027f683e05e5fc01dd9714b8b4fa
  CHECKSUM(SHA256) upstream package : 0318e4256539b6830aaea284dc5dc336b970027f683e05e5fc01dd9714b8b4fa


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1494979
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6


Issues:
- please remove the %clean section. It is not required
- please move the %files sections to the bottom
- please move the changelog at the very bottom
- %packages and %descriptions of packages should be moved before %prep section
  (see for reference: https://src.fedoraproject.org/rpms/python-pbr/blob/master/f/python-pbr.spec )
- https://github.com/omeranson/jsonmodels/blob/rpm-spec/rpm/python-jsonmodels.spec#L14 should become 
  %if 0%{?use_tests}
- please remove the . from the summary of python2-jsonmodels
- same for python3
- please fix the line-length for python2 and python3-jsonmodels description.

Done, and updated the links.

Providing the links again.

SPEC: https://raw.githubusercontent.com/omeranson/jsonmodels/rpm-spec/rpm/python-jsonmodels.spec
SRPM: https://github.com/omeranson/jsonmodels/raw/rpm-spec/rpm/python-jsonmodels-2.2-1.fc27.src.rpm

Although your informal reviews were very(!) brief, and you took haskell packages instead of python packages, I'm good to continue here.


You're still throwing around use_test and python3 subpackages (it is not clear from reading the spec file, why tests and python3 are related). Maybe it's a better idea to split that into two globals, as one could skip tests even with python3 enabled?

Could you please fix that and then we should be done.

Thanks for your comments.

Done.

ok, my concerns were addressed. Package approved

Omer, I've added you to the packager group, please continue to request branches for fedora. You're also free to request addition to rdo

Thanks.

Branch request done in https://pagure.io/releng/fedora-scm-requests/issue/3152 .

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jsonmodels

Opened RDO request here: https://bugzilla.redhat.com/show_bug.cgi?id=1525362