Bug 1495005
| Summary: | livecd-creator crashes due to missing "b" in live.py on line 497 and 581 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | upgradeservices |
| Component: | livecd-tools | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 26 | CC: | adam.stokes, bcl, bruno, dhuff, extras-orphan, katzj, ngompa13, pviktori, python-sig, TicoTimo |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | livecd-tools-25.0-1.fc26 livecd-tools-25.0-1.fc27 livecd-tools-25.0-1.fc25 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-10-30 16:18:30 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Fixed in master: https://github.com/livecd-tools/livecd-tools/commit/89b116cc2926bffe420c24c95f26b11f3d1ddd41 Thank you very much, the fix resolved the problem. livecd-tools-25.0-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-86b225030b livecd-tools-25.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-56598fe991 livecd-tools-25.0-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4c20585902 livecd-tools-25.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-56598fe991 livecd-tools-25.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4c20585902 livecd-tools-25.0-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-86b225030b livecd-tools-25.0-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. livecd-tools-25.0-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. livecd-tools-25.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: in /usr/lib/python3.6/site-packages/imgcreate/live.py on line 497 if kernel.startswith("kernel-") and kernel[7:] == self._default_kernel: it should be: if kernel.startswith(b"kernel-") and kernel[7:] == self._default_kernel: on line 581 elif kernel.startswith("kernel-"): it should be: elif kernel.startswith(b"kernel-"): Otherwise livecd-creator will throw an error when reading current kernel version. "TypeError: startswith first arg must be bytes or a tuple of bytes, not str" Version-Release number of selected component (if applicable): python3-imgcreate-24.4-1.fc26.x86_64 How reproducible: Each time Steps to Reproduce: 1. livecd-creator spin 2. 3. Actual results: Crashes with "TypeError: startswith first arg must be bytes or a tuple of bytes, not str" Expected results: Not crash Additional info: I've tested adding "b" as suggested above and the spin completed successfully, with kernel version read in correctly.