Bug 1495387

Summary:	Review Request: nodejs-acorn-jsx - Alternative, faster React.js JSX parser
Product:	[Fedora] Fedora	Reporter:	Jared Smith <jsmith.fedora>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-30 15:01:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	956806, 1387531, 1495390, 1583859

Description Jared Smith 2017-09-26 00:29:47 UTC

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-acorn-jsx/nodejs-acorn-jsx.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-acorn-jsx/nodejs-acorn-jsx-4.0.1-1.fc28.src.rpm
Description: Alternative, faster React.js JSX parser
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 🐧 2017-09-26 12:19:17 UTC

Tests fail:

/builddir/build/BUILD/package/inject.js:12
  tc.j_oTag = new acorn.TokContext('<tag', false);
              ^
TypeError: acorn.TokContext is not a constructor
    at module.exports (/builddir/build/BUILD/package/inject.js:12:15)
    at Object.<anonymous> (/builddir/build/BUILD/package/index.js:3:37)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Module.require (module.js:568:17)
    at require (internal/module.js:11:18)
    at [eval]:1:1

Comment 2 Jared Smith 2018-05-29 20:41:43 UTC

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-acorn-jsx/nodejs-acorn-jsx.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-acorn-jsx/nodejs-acorn-jsx-4.1.1-1.fc29.src.rpm

Comment 3 Robert-André Mauchin 🐧 2018-05-29 21:20:22 UTC

 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 4 Jared Smith 2018-05-29 21:57:24 UTC

Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6802.

Comment 5 Gwyn Ciesla 2018-05-29 23:17:32 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-acorn-jsx

Comment 6 Jared Smith 2018-05-30 15:01:00 UTC

Packaged in Rawhide, closing this issue