Bug 1495397

Summary:	Make event-history feature configurable and have it disabled by default
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	core	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-glusterfs-3.12.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-13 12:46:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1467614
Bug Blocks:

Description Krutika Dhananjay 2017-09-26 01:13:53 UTC

Description of problem:
This is because having it disabled seems to improve performance.
This could be due to the lock contention by the different epoll threads
on the circular buff lock in the fop cbks just before writing their response
to /dev/fuse.

Just to provide some data - wrt ovirt-gluster hyperconverged
environment, I saw an increase in IOPs by 12K with event-history
disabled for randrom read workload.

Usage:
mount -t glusterfs -o event-history=on $HOSTNAME:$VOLNAME $MOUNTPOINT
OR
glusterfs --event-history=on --volfile-server=$HOSTNAME --volfile-id=$VOLNAME $MOUNTPOINT


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2017-09-26 02:49:04 UTC

REVIEW: https://review.gluster.org/18387 (mount/fuse: Make event-history feature configurable) posted (#1) for review on release-3.12 by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2017-09-26 03:52:54 UTC

REVIEW: https://review.gluster.org/18387 (mount/fuse: Make event-history feature configurable) posted (#2) for review on release-3.12 by Krutika Dhananjay (kdhananj)

Comment 3 Worker Ant 2017-10-05 12:02:46 UTC

COMMIT: https://review.gluster.org/18387 committed in release-3.12 by jiffin tony Thottan (jthottan) 
------
commit 761942e9fe8f6d7bbd5c56720e52dc4f6663cd9f
Author: Krutika Dhananjay <kdhananj>
Date:   Thu Sep 7 18:48:34 2017 +0530

    mount/fuse: Make event-history feature configurable
    
    ... and disable it by default.
    
            Backport of:
            > Change-Id: Ia533788d309c78688a315dc8cd04d30fad9e9485
            > Reviewed-on: https://review.gluster.org/18242
            > BUG: 1467614
            > cherry-picked from commit 956d43d6e89d40ee683547003b876f1f456f03b6
    
    This is because having it disabled seems to improve performance.
    This could be due to the lock contention by the different epoll threads
    on the circular buff lock in the fop cbks just before writing their response
    to /dev/fuse.
    
    Just to provide some data - wrt ovirt-gluster hyperconverged
    environment, I saw an increase in IOPs by 12K with event-history
    disabled for randrom read workload.
    
    Usage:
    mount -t glusterfs -o event-history=on $HOSTNAME:$VOLNAME $MOUNTPOINT
    OR
    glusterfs --event-history=on --volfile-server=$HOSTNAME --volfile-id=$VOLNAME $MOUNTPOINT
    
    Change-Id: Ia533788d309c78688a315dc8cd04d30fad9e9485
    BUG: 1495397
    Signed-off-by: Krutika Dhananjay <kdhananj>

Comment 4 Jiffin 2017-10-13 12:46:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.2, please open a new bug report.

glusterfs-glusterfs-3.12.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-October/032684.html
[2] https://www.gluster.org/pipermail/gluster-users/