Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1495500

Summary:	Global collectd configurations that are set in collectd.d/ will not apply to plugins that are loaded in collectd.conf
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Shirly Radco <sradco>
Component:	collectd	Assignee:	Yedidyah Bar David <didi>
Status:	CLOSED ERRATA	QA Contact:	Lukas Svaty <lsvaty>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.2.0	CC:	bgraveno, didi, sradco, ylavi
Target Milestone:	ovirt-4.2.0
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	collectd-5.7.2-3.el7	Doc Type:	Bug Fix
Doc Text:	collectd's default configuration file /etc/collectd.conf is no longer used to load any plugins. Each plugin is now loaded from its own separate file which is included in the rpm. For example: - /etc/collectd.d/90-default-plugins-cpu.conf - /etc/collectd.d/90-default-plugins-interface.conf - /etc/collectd.d/90-default-plugins-load.conf - /etc/collectd.d/90-default-plugins-memory.conf If a 3rd-party wants to affect the configuration of one or more plugins, it needs its own file to be loaded before those provided by the plugins.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-05-15 17:54:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1478695

Description Shirly Radco 2017-09-26 08:10:38 UTC

Description of problem:

Global collectd configurations that are set in collectd.d/ will not apply to plugins that are loaded in collectd.conf.

For example, if we add a file to collectd.d/ that sets collectd Interval to one that is different from the default 10 sec, It will not affect the plugins that are loaded in collectd.conf.

All plugins in collectd.conf should be commented out and they should be loaded from a file in collecd.d/ instead.

Version-Release number of selected component (if applicable):
5.7.2

How reproducible:
100%

Steps to Reproduce:
1. Add like 00-global_collectd.conf and set Interval 60
2. Restart collectd
3. Review result for plugins that are loaded from the collectd.conf like cpu, memory, interface.

Actual results:
The plugins that are loaded from collectd.conf stay with the same configs as set in the collectd.conf.

Expected results:
Should be able to update all plugin configurations from collectd.d/

Additional info:

Comment 3 Shirly Radco 2017-10-30 06:02:47 UTC

Didi has fixed the issue in centos-opstools.
https://review.rdoproject.org/r/#/c/9802/

Packages needs to be built before this bug can be built before this bug can be fixed and tested.

Comment 4 Shirly Radco 2017-10-30 06:04:16 UTC

Can we change to modified?

Comment 7 Lukas Svaty 2017-11-03 15:08:05 UTC

What parameter should be taken instead of conflict? First defined? sub-dir?

Comment 8 Lukas Svaty 2017-12-14 15:42:02 UTC

Shirly - ping

Comment 9 Yedidyah Bar David 2017-12-17 06:40:07 UTC

(In reply to Lukas Svaty from comment #7)
> What parameter should be taken instead of conflict? First defined? sub-dir?

Not sure what's the question here, but to clarify - nothing in collectd's behavior/functionality was changed.

The only change is in the default collectd.conf. It's now doing nothing except for Include collectd.d.

In principle, verification of bug 1478695 should be enough also for current bug.

Comment 10 Lukas Svaty 2018-01-23 16:37:31 UTC

verified in collectd-5.7.2-3.el7.x86_64

Comment 12 Yedidyah Bar David 2018-05-08 10:15:49 UTC

Byron, I do not think the new doc text means what I wanted to imply in the previous one. Tried suggesting a different text, but can't get it right and still much shorter than previous. So instead I'll write in much more detail how we solved the problem. See comment 0 for an explanation of the problem itself. Feel free to update the doc text accordingly.

With the fixed version (5.7.2-3), the collectd rpm, when installed, provides a file /etc/collectd.conf which is different from previous versions - it does not load any plugins there anymore. Instead, each of the plugins we want to load by default is loaded from its own separate file, and these files are also now included in the rpm (so you get them if you install it):

/etc/collectd.d/90-default-plugins-cpu.conf
/etc/collectd.d/90-default-plugins-interface.conf
/etc/collectd.d/90-default-plugins-load.conf
/etc/collectd.d/90-default-plugins-memory.conf
/etc/collectd.d/90-default-plugins-syslog.conf

So the default behavior, of loading these plugins by default, did not change at all.

In addition, now, if a 3rd-party (such as the ovirt-engine-metrics project) wants to affect the configuration of one or more of these plugins, such a 3rd party can add its own file, to be loaded before these ones, with the needed options. This is much simpler than having to edit /etc/collectd.conf and add the needed options _before_ the relevant LoadPlugin commands.

This bug, although is in Product RHV, is regarded as a general "collectd" bug. See bug 1478695 for what we actually wanted. Also, if we decide that current bug needs doc text, perhaps bug 1478695 does too.

Comment 14 errata-xmlrpc 2018-05-15 17:54:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:1490

Comment 15 Franta Kust 2019-05-16 13:05:15 UTC

BZ<2>Jira Resync