Bug 1495971

Summary: setting a dynamic dialog to "required = True" is not saved
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: ProvisioningAssignee: eclarizi
Status: CLOSED ERRATA QA Contact: Shveta <sshveta>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: cpelland, ealcaniz, fdewaley, gmccullo, jhardy, obarenbo, simaishi, smallamp
Target Milestone: GAKeywords: ZStream
Target Release: 5.7.4   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.7.4.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1492150 Environment:
Last Closed: 2017-12-18 20:30:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1492150    
Bug Blocks:    

Comment 2 CFME Bot 2017-09-26 13:36:04 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/1a7396e2eb8c374f9592f6e96cce81c86f429d16

commit 1a7396e2eb8c374f9592f6e96cce81c86f429d16
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Sep 18 19:41:49 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Tue Sep 26 09:31:33 2017 -0400

    Merge pull request #2185 from eclarizio/BZ1492150
    
    Ensure the 'required' property gets saved for dynamic drop down fields
    (cherry picked from commit ac02d7b602fc71702e4641f759c79ec14aee0436)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1495971

 app/controllers/miq_ae_customization_controller/dialogs.rb  |  1 +
 .../_dialog_field_form_dynamic_options.html.haml            | 13 ++++---------
 .../_dialog_field_form_non_dynamic_options.html.haml        | 11 +++--------
 3 files changed, 8 insertions(+), 17 deletions(-)

Comment 3 CFME Bot 2017-10-09 17:06:18 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/7a95d49b47b434cbd3d6e7d2b223ebdc53fe33e0

commit 7a95d49b47b434cbd3d6e7d2b223ebdc53fe33e0
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Oct 9 12:18:33 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Oct 9 13:04:26 2017 -0400

    Merge pull request #2313 from eclarizio/allow_required_flag_for_all_dialog_field_types
    
    Allow required flag to be set/unset for all dialog field types
    (cherry picked from commit f40bb3ba78cd2d5e048da06398b46123d37ced2b)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1495971

 app/controllers/miq_ae_customization_controller/dialogs.rb | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

Comment 4 CFME Bot 2017-10-23 14:26:11 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/0fef466a8bf9cc61b684417a8f28d5427e62b155

commit 0fef466a8bf9cc61b684417a8f28d5427e62b155
Author:     Greg McCullough <gmccullo>
AuthorDate: Wed Oct 11 09:25:07 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Oct 23 10:21:10 2017 -0400

    Merge pull request #16167 from eclarizio/BZ1496946-part2
    
    Refactor #values and #raw_values methods to improve default value setup
    (cherry picked from commit a4ff07953ac5b3c6dae525c13a117431cdb2cca7)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1495971

 app/models/dialog_field_sorted_item.rb          |  32 +++-
 spec/models/dialog_field_drop_down_list_spec.rb | 195 +++++++++++++++++-------
 spec/models/dialog_field_sorted_item_spec.rb    |   3 +-
 3 files changed, 167 insertions(+), 63 deletions(-)

Comment 5 CFME Bot 2017-10-23 14:26:17 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/18e530a7690e564c378e33a400a8043591e6b499

commit 18e530a7690e564c378e33a400a8043591e6b499
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Oct 10 17:56:50 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Mon Oct 23 10:19:45 2017 -0400

    Merge pull request #2340 from eclarizio/BZ1496946-part2
    
    Add a blank option in drop down default value selections
    (cherry picked from commit 818ac60350306413a6a00240e85d1582ed9442b0)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1495971

 app/helpers/application_helper/dialogs.rb          |  5 +-
 ...dialog_field_form_non_dynamic_options.html.haml |  2 +-
 spec/helpers/application_helper/dialogs_spec.rb    | 93 ++++++----------------
 3 files changed, 27 insertions(+), 73 deletions(-)

Comment 6 Shveta 2017-11-27 21:12:53 UTC
Fixed in 5.7.4.1.20171114202358_de8178a

Comment 9 errata-xmlrpc 2017-12-18 20:30:12 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3484