Bug 1496720

Summary: [TEXT] - Fix minor error in ' Some MAC addresses had to be reallocated, but operation failed becaue of insufficient amount of free MACs.'
Product: [oVirt] ovirt-engine Reporter: Michael Burman <mburman>
Component: BLL.NetworkAssignee: Dan Kenigsberg <danken>
Status: CLOSED CURRENTRELEASE QA Contact: Michael Burman <mburman>
Severity: low Docs Contact:
Priority: low    
Version: 4.2.0CC: bugs, danken
Target Milestone: ovirt-4.1.7Flags: rule-engine: ovirt-4.1+
rule-engine: ovirt-4.2+
Target Release: 4.1.7.3   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-13 12:28:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description Michael Burman 2017-09-28 08:35:20 UTC
Created attachment 1331831 [details]
screenshot

Description of problem:
The 'becaue' word missing 's' 

"Some MAC addresses had to be reallocated, but operation failed becaue of insufficient amount of free MACs.
"

Version-Release number of selected component (if applicable):
ovirt-engine-4.2.0-0.0.master.20170927183005.git49790b2.el7.centos.noarch

How reproducible:
100

Steps to Reproduce the error message:
1. 2 VMs in the cluster
2. MAC pool range with only 1 MAC address
3. Add 1 vNIC to VM1 and run it
4. Create snapshot from VM1
5) Unplug the vNIC from VM1 and assign MAC address not from the pool
6) Add vNIC to VM2 with the origin MAC address of VM1
7) Try to preview VM1 from snapshot

Actual results:
Operation failed with error - 'Some MAC addresses had to be reallocated, but operation failed becaue of insufficient amount of free MACs.'

Expected results:
Some MAC addresses had to be reallocated, but operation failed because of insufficient amount of free MACs.


Additional info:
Note that for the positive scenario(when we do have enough MACs to allocate), then we show a warning and the message has no mistake - 
'Some MAC addresses had to be reallocated because they are duplicate.'

Comment 1 Michael Burman 2017-10-01 05:48:27 UTC
Verified on - 4.2.0-0.0.master.20170929123516.git007c392.el7.centos

Comment 2 Michael Burman 2017-10-01 06:50:09 UTC
Want to fix it for 4.1.z as well? or to keep the error message with the tiny English typo for 4.1?

Comment 3 Dan Kenigsberg 2017-10-01 07:26:12 UTC
Whatever you say, sir.

Comment 4 Michael Burman 2017-10-15 08:09:10 UTC
Verified on - 4.1.7.3-0.1.el7