Description of problem:
A rados lock is used to prevent racing CompleteMultipartUpload requests on the same object. But if we fail the request (due to invalid arguments, missing parts, etc), the lock is not released.
This causes later CompleteMultipartUpload requests on that object to fail with '500 Internal Error' and log:
> RGWCompleteMultipart::execute() failed to acquire lock
Version-Release number of selected component (if applicable):
ceph-12.2.0-2.el7cp
How reproducible:
After a failed CompleteMultipartUpload request, all later CompleteMultipartUpload requests on that object will fail with '500 Internal Error' for a duration of rgw_mp_lock_max_time (default: 10 minutes)
Steps to Reproduce:
1. Create an object
2. Issue a CompleteMultipartUpload on that object with an invalid upload id
3. Reissue the same invalid CompleteMultipartUpload request
Actual results:
The first request fails with 404 NoSuchUpload, and the second request fails with this 500 InternalError:
botocore.exceptions.ClientError: An error occurred (InternalError) when calling the CompleteMultipartUpload operation (reached max retries: 4): This multipart completion is already in progress
Expected results:
Both requests should fail with 404 NoSuchUpload.
Additional info:
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
https://access.redhat.com/errata/RHBA-2017:2903
Description of problem: A rados lock is used to prevent racing CompleteMultipartUpload requests on the same object. But if we fail the request (due to invalid arguments, missing parts, etc), the lock is not released. This causes later CompleteMultipartUpload requests on that object to fail with '500 Internal Error' and log: > RGWCompleteMultipart::execute() failed to acquire lock Version-Release number of selected component (if applicable): ceph-12.2.0-2.el7cp How reproducible: After a failed CompleteMultipartUpload request, all later CompleteMultipartUpload requests on that object will fail with '500 Internal Error' for a duration of rgw_mp_lock_max_time (default: 10 minutes) Steps to Reproduce: 1. Create an object 2. Issue a CompleteMultipartUpload on that object with an invalid upload id 3. Reissue the same invalid CompleteMultipartUpload request Actual results: The first request fails with 404 NoSuchUpload, and the second request fails with this 500 InternalError: botocore.exceptions.ClientError: An error occurred (InternalError) when calling the CompleteMultipartUpload operation (reached max retries: 4): This multipart completion is already in progress Expected results: Both requests should fail with 404 NoSuchUpload. Additional info: