Bug 1497007

One or more of the specfile's Sources is not a valid URL so we cannot automatically build the new version for you. Please use a URL in your Source declarations if possible.

tibbs's amanda-3.5-1.fc28 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=976853

Note that 3.5 appears to need at least one configuration file change (tcp_port_range in amanda-security.conf) so even if the update otherwise works fine, I don't think it's a great idea to push this down to F26/25 without further thought.  It may be only that amcheck complains about the missing configuration item, but even then it's not a good idea to start spamming the admins with that in the middle of a release.

In this case, I recommend to do the rebase only for rawhide and f27.

Jason, could you do that and push it to bodhi? 

Thanks

I've been out of town for a week, sorry.

I did originally build for rawhide but hadn't wanted to push it to any release branch until I had a chance to at least give it some kind of testing locally.  But I'll go ahead and merge master to f27 and generate an update.

It turns out that the package needs further fixes.  At least some things must not be setuid while the new ambind program must be.  So I'm going to do some additional testing before pushing those fixes out.

Just a note that I have been running the current rawhide package on both my server and some F27 clients without issue for the past few days.  I thought there would be some necessary configuration in amanda-security.conf, but that doesn't appear to be necessary, so technically there doesn't appear to be any technical reason we couldn't push the newer version.  It would be more of a question of policy.

Personally I think I'd avoid pushing it in the absence of any bug reports against the older version out of an overabundance of caution.

Also, while  note that amanda-client contains both /etc/amanda-security.conf and /etc/amanda/amanda-security.conf.  Both were added in the same commit (7c14a94) and honestly I don't know what to do about them.  One is %config(noreplace) while the other isn't.

Hi Jason,

I totally agree with you. I prefer to have this version in Rawhide, unless it will solve some issue reported against F27.

To amanda-security.conf files from amanda-security.conf man page:

The file must be installed at/etc/amanda-security.conf and only root must be able to write to it. An example file should be installed at /etc/amanda/amanda-security.conf.

So I hope, that actual file settings are correct.

OK, so I guess we can close this since the package doesn't currently need to go any further than rawhide.

You're right about amanda-security.conf, though... that's really bizarre.  It would be nice if they had used a different name for the example file because eventually someone will be confused but I guess there's no point in trying to change it.  The example file doesn't even indicate that it's an example, so there's a high probability that someone might try to edit it and then be surprised that the changes don't take effect.  And if we didn't install it (or renamed it) then someone would read the documentation and complain that the example file is not where the documentation says it is.

Oh, well.