Bug 1497168

Summary:	Upgrade should be blocked if etcd3 is not currently in use
Product:	OpenShift Container Platform	Reporter:	liujia <jiajliu>
Component:	Cluster Version Operator	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	liujia <jiajliu>
Severity:	high	Docs Contact:
Priority:	high
Version:	3.7.0	CC:	aos-bugs, jokerman, mmccomas
Target Milestone:	---
Target Release:	3.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-28 22:13:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description liujia 2017-09-29 11:03:21 UTC

Description of problem:
Run pre-upgrade/upgrade against ocp v3.6(upgraded from v3.5), pre-upgrade/upgrade should be blocked for no migration to etcd3. But actually verify_etcd3_backend.yml seems be skipped and upgrade can continue and succeed.

Version-Release number of the following components:
# rpm -qa|grep openshift
openshift-ansible-filter-plugins-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
openshift-ansible-playbooks-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
openshift-ansible-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
openshift-ansible-callback-plugins-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
openshift-ansible-roles-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
atomic-openshift-utils-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
openshift-ansible-docs-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
openshift-ansible-lookup-plugins-3.7.0-0.134.0.git.0.6f43fc3.el7.noarch
etcd-3.2.5-1.el7.x86_64


How reproducible:
always

Steps to Reproduce:
1. Install ocp v3.5
2. Upgrade ocp v3.5 to v3.6, but without etcd migration. 
# cat /etc/origin/master/master-config.yaml |grep -E 'etcd3|backend|storage'
3. Upgrade ocp v3.6 to v3.7


Actual results:
verify_etcd3_backend.yml was skipped and upgrade could continue and succeed.

Expected results:
Upgrade should be blocked if etcd3 is not currently in use 

Additional info:
inventory file and upgrade log in attachment.

Comment 3 Jan Chaloupka 2017-09-29 13:32:47 UTC

Upstream PR: https://github.com/openshift/openshift-ansible/pull/5520

Comment 4 Jan Chaloupka 2017-09-29 14:58:20 UTC

Upstream PR: https://github.com/openshift/openshift-ansible/pull/5593

The previous PR was checking the backend storage only if the control plane was upgraded. This checks the backend storage during the cluster upgrade.

Comment 5 liujia 2017-10-09 09:08:53 UTC

Version:
openshift-ansible-3.7.0-0.144.2.git.0.da1dd6c.el7.noarch

1. Install ocp v3.5
2. Upgrade ocp v3.5 to v3.6, but without etcd migration. 
# cat /etc/origin/master/master-config.yaml |grep -E 'etcd3|backend|storage'
3. Upgrade ocp v3.6 to v3.7

Upgrade was blocked for etcd3 is not currently in use.

Comment 9 errata-xmlrpc 2017-11-28 22:13:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188