Bug 1497501

Summary: /usr/include/sys/mount.h:35:3: error: expected identifier before numeric constant
Product: [Fedora] Fedora Reporter: Andrew Vagin <avagin>
Component: glibcAssignee: Carlos O'Donell <codonell>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 28CC: adrian, aoliva, arjun.is, codonell, dj, fweimer, jakub, law, mfabian, pfrankli, siddhesh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-28 19:27:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andrew Vagin 2017-10-01 06:07:26 UTC
Description of problem:

It is impossible to use linux/aio_abi.h and sys/mount.h together.

[root@fc24 ~]# cat test.c
#include <linux/aio_abi.h>
#include <sys/mount.h>

int main()
{
	return 0;
}
[root@fc24 ~]# gcc test.c
In file included from /usr/include/linux/aio_abi.h:31:0,
                 from test.c:1:
/usr/include/sys/mount.h:35:3: error: expected identifier before numeric constant
   MS_RDONLY = 1,  /* Mount read-only.  */
   ^

Version-Release number of selected component (if applicable):


How reproducible:
100%

https://lists.openvz.org/pipermail/criu/2017-September/039510.html

Comment 1 Andrew Vagin 2017-10-01 06:17:53 UTC
A new aio_abi.h includes linux/fs.h.
--- /usr/include/linux/aio_abi.h        2017-10-01 09:10:29.265000000 +0300
+++ aio_abi.h   2017-09-30 10:11:03.499000000 +0300
@@ -28,6 +28,7 @@
 #define __LINUX__AIO_ABI_H
 
 #include <linux/types.h>
+#include <linux/fs.h>
 #include <asm/byteorder.h>

man 2 mounts says that we need to include sys/mount.h
man 2 io_getevents says that we need to include linux/aio_abi.h

There is not information, that linux/aio_abi.h has to be included before sys/mount.h.

Comment 2 Carlos O'Donell 2017-10-05 05:53:13 UTC
This is a kernel and glibc header coordination issue.

https://sourceware.org/glibc/wiki/Synchronizing_Headers

Each needs to be fixed manually.

Some headers work only in certain ordering.

This needs to be fixed upstream.

Comment 3 Fedora End Of Life 2018-02-20 15:22:52 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.

Comment 4 Ben Cotton 2019-05-02 19:18:19 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Ben Cotton 2019-05-02 22:07:50 UTC
This message is a reminder that Fedora 28 is nearing its end of life.
On 2019-May-28 Fedora will stop maintaining and issuing updates for
Fedora 28. It is Fedora's policy to close all bug reports from releases
that are no longer maintained. At that time this bug will be closed as
EOL if it remains open with a Fedora 'version' of '28'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 28 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Ben Cotton 2019-05-28 19:27:19 UTC
Fedora 28 changed to end-of-life (EOL) status on 2019-05-28. Fedora 28 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.