Bug 1497708
Summary: | Expose host hugepages to REST API | ||
---|---|---|---|
Product: | [oVirt] ovirt-engine | Reporter: | Artyom <alukiano> |
Component: | RestAPI | Assignee: | Tomas Jelinek <tjelinek> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Lucie Leistnerova <lleistne> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.2.0 | CC: | alukiano, bugs, lleistne, michal.skrivanek, tjelinek |
Target Milestone: | ovirt-4.2.0 | Flags: | rule-engine:
ovirt-4.2+
|
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-12-20 11:03:31 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Artyom
2017-10-02 13:44:39 UTC
Why is that information needed? Why via the API? 1) I believe we need to mirror all data that I can see via UI to REST 2) In my automation test, I want to check a number of host hugepages after update of /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages and I can not do it Not saying that we should not add that, but we can't add everything that is available in /sys/kernel. Can't yo reach the host via SSH go get that information? This information already exposed to UI Huge Pages (size: amount): 1048576: 0, 2048: 0 It also available via vdsm-client Host getStats ... "hugepages": { "1048576": { "resv_hugepages": 0, "free_hugepages": 0, "nr_overcommit_hugepages": 0, "surplus_hugepages": 0, "vm.free_hugepages": 0, "nr_hugepages": 0, "nr_hugepages_mempolicy": 0 }, "2048": { "resv_hugepages": 0, "free_hugepages": 0, "nr_overcommit_hugepages": 0, "surplus_hugepages": 0, "vm.free_hugepages": 0, "nr_hugepages": 0, "nr_hugepages_mempolicy": 0 } } ... so I do not tell to take it from file that I specified above, I just ask to expose to REST the same thing that we have under UI The fact that it exists in the UI doesn't mean that it needs to be in the API. If we add it to the API, then we need to keep it there for ever, with the corresponding maintenance overhead. That overhead is probably small in this particular case, but if there is another mechanism that you can use to get the same information without the API (like SSH, or vdsm-client), and there is no need for this expressed by other users of the API, then I'd rather don't add it. Michal, what do you think? The problem that I want to know via REST API when the engine has updated information about an amount of host hugepages, I just want to avoid adding some sleep function to my code. I agree with Artyom here, this is an information which is useful if you want to create a VM with huge pages which is important for the new high perf VMs feature. And adding it will be easy, so will be the maintenance, so I will target to 4.2 done? yes API returns in statistics free hugepages for every size e.g. hugepages.2048.free. If that is not enough informations feel free to open new BZ to add other values. verified in ovirt-engine-restapi-4.2.0-0.6.el7.noarch with vdsm-4.20.9-1.el7ev.x86_64 This bugzilla is included in oVirt 4.2.0 release, published on Dec 20th 2017. Since the problem described in this bug report should be resolved in oVirt 4.2.0 release, published on Dec 20th 2017, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |