Bug 1498037
| Summary: | Review Request: php-pecl-mcrypt - Bindings for the libmcrypt library | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | package-review, shawn | ||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-10-23 12:36:11 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2017-10-03 11:29:55 UTC
Created attachment 1341378 [details] fedora-review.txt Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 1498037 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 [!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see
attached diff).
See: (this test has no URL)
Diffs are just removing SCL bits and cleaning up from remirepo to Fedora
No blockers
===== APPROVED =====
Thanks for the review fedrepo request: https://pagure.io/releng/fedora-scm-requests/issue/2356 > Diffs are just removing SCL bits and cleaning up from remirepo to Fedora I'd like to understand how this happen, was thinking to a mistake from me in above links, but everything seems ok... The spec URL in comment 1 is the fedora one (without SCL) The spec from the .src.rpm in the linked URL is the same. :( $ wget https://git.remirepo.net/cgit/rpms/php/pecl/php-pecl-mcrypt.git/plain/php-pecl-mcrypt.spec?id=8d2bbb722d241a029c5f4bc1c647e77be7d6e51b -O spec $ wget http://rpms.remirepo.net/SRPMS/php-pecl-mcrypt-1.0.1-1.fedora.7.0.src.rpm $ rpmdev-extract php-pecl-mcrypt-1.0.1-1.fedora.7.0.src.rpm $ diff spec php-pecl-mcrypt-1.0.1-1.fedora.7.0.src/php-pecl-mcrypt.spec And indeed, fedora-review download the bad spec.... Very strange @shawn bug #1505030 open to track this issue (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-pecl-mcrypt |