Bug 1498544

Summary: Some Navigation menus are not highlighted
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Martin Povolny <mpovolny>
Status: CLOSED ERRATA QA Contact: Matouš Mojžíš <mmojzis>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8.0CC: ewinchel, hkataria, jhardy, lkhomenk, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.8.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: general_ui:navigation
Fixed In Version: 5.8.3.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1472844 Environment:
Last Closed: 2018-02-28 13:06:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1472844    
Bug Blocks:    

Comment 2 Martin Povolny 2017-10-17 04:59:13 UTC
https://github.com/ManageIQ/manageiq-ui-classic/pull/2368

"Some" navigation menus are fixed.

Actually all should be fixed except for storage: "Block Storage" vs "Object Storage". That on is not fixable w/o significant changes is not going to be fixed for 5.8.

Comment 3 CFME Bot 2017-11-02 18:19:32 UTC
New commit detected on ManageIQ/manageiq-ui-classic/fine:
https://github.com/ManageIQ/manageiq-ui-classic/commit/339e765823f76787b160dd35c74b9e24205bdfc3

commit 339e765823f76787b160dd35c74b9e24205bdfc3
Author:     Harpreet Kataria <hkataria>
AuthorDate: Wed Aug 16 16:03:43 2017 -0400
Commit:     Satoe Imaishi <simaishi>
CommitDate: Thu Nov 2 14:18:09 2017 -0400

    Merge pull request #1915 from martinpovolny/menu_active_fixes
    
    Menu active item fixes
    (cherry picked from commit 6c543ea8c187ca2fdb387e2f3d56763d525f8032)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1498516
    https://bugzilla.redhat.com/show_bug.cgi?id=1498511
    https://bugzilla.redhat.com/show_bug.cgi?id=1498518
    https://bugzilla.redhat.com/show_bug.cgi?id=1498506
    https://bugzilla.redhat.com/show_bug.cgi?id=1498544

 app/controllers/automation_manager_controller.rb |  2 +-
 app/controllers/configuration_job_controller.rb  |  2 +-
 app/controllers/middleware_domain_controller.rb  |  2 +-
 app/controllers/miq_request_controller.rb        | 11 ++++++++---
 app/helpers/application_helper.rb                | 16 ++++++++++++++++
 app/presenters/menu/default_menu.rb              |  2 +-
 6 files changed, 28 insertions(+), 7 deletions(-)

Comment 4 Matouš Mojžíš 2018-01-09 14:34:07 UTC
Verified in 5.8.3.0. These navigation menu items are highlighted.

Comment 7 errata-xmlrpc 2018-02-28 13:06:20 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0374