Bug 1499617

Summary:	Review Request: adwaita-blue-gtk-theme - Adwaita Blue GTK theme variant
Product:	[Fedora] Fedora	Reporter:	Ryan Lerch <rlerch>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-07 12:57:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ryan Lerch 2017-10-09 05:35:05 UTC

Spec URL: https://ryanlerch.fedorapeople.org/adwaita-blue-gtk-theme.spec
SRPM URL: https://ryanlerch.fedorapeople.org/adwaita-blue-gtk-theme-3.22.21.0-0.fc26.src.rpm
Description: Adwaita GTK theme variant with blue titlebars and headerbars
Fedora Account System Username: ryanlerch

Comment 1 Robert-André Mauchin 🐧 2017-10-09 11:33:00 UTC

Hello,

 - Use:

Source0: https://github.com/ryanlerch/adwaita-blue/releases/download/v%{version}/adwaita-blue-%{version}.tar.gz 

 - Do not include these empty files:

adwaita-blue-gtk-theme.noarch: E: zero-length /usr/share/doc/adwaita-blue-gtk-theme/AUTHORS
adwaita-blue-gtk-theme.noarch: E: zero-length /usr/share/doc/adwaita-blue-gtk-theme/NEWS
adwaita-blue-gtk-theme.noarch: E: zero-length /usr/share/doc/adwaita-blue-gtk-theme/README

 - GPL is not a valid license shorthand. Use either GPLv3 or GPLv3+

License: GPLv3

Comment 2 Ryan Lerch 2017-10-10 07:16:24 UTC

Thanks for the review!

Have updated the SPEC and SRPM with your recommendations. 

Spec URL: https://ryanlerch.fedorapeople.org/adwaita-blue-gtk-theme.spec
SRPM URL: https://ryanlerch.fedorapeople.org/adwaita-blue-gtk-theme-3.22.21.0-0.fc26.src.rpm

Comment 3 Robert-André Mauchin 🐧 2017-10-10 08:03:52 UTC

Perfect, package accepted.

Comment 4 Gwyn Ciesla 2017-10-11 12:49:07 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/adwaita-blue-gtk-theme

Comment 5 Mattia Verga 2021-06-07 12:57:29 UTC

Package has been imported, closing ticket.