Bug 1499641

Summary:	gfapi: API needed to set lk_owner
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	libgfapi	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1500704 1501955 1501956 (view as bug list)		Environment:
Last Closed:	2017-12-08 17:43:00 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1500704, 1501955, 1501956

Description Soumya Koduri 2017-10-09 07:33:56 UTC

Description of problem:

Glusterfs server differentiates locks based on both client-id and lock owner. There is no provision to set lk_owner as of now via gfapi. Hence a new API is needed to set the same. Since the lk_owner is associated with a particular glfd (until we get mandatory lk support), the API definition looks like below -

"glfd_set_lk_owner()"


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Soumya Koduri 2017-10-09 07:34:27 UTC

https://review.gluster.org/#/c/18429

Comment 2 Worker Ant 2017-10-09 10:06:12 UTC

REVIEW: https://review.gluster.org/18429 (gfapi: set lkowner in glfd) posted (#3) for review on master by soumya k (skoduri)

Comment 3 Worker Ant 2017-10-10 11:57:54 UTC

REVIEW: https://review.gluster.org/18429 (gfapi: set lkowner in glfd) posted (#4) for review on master by soumya k (skoduri)

Comment 4 Worker Ant 2017-10-12 10:42:51 UTC

REVIEW: https://review.gluster.org/18429 (gfapi: set lkowner in glfd) posted (#5) for review on master by soumya k (skoduri)

Comment 5 Worker Ant 2017-10-13 07:48:04 UTC

COMMIT: https://review.gluster.org/18429 committed in master by Niels de Vos (ndevos) 
------
commit c22cec3928be6924fb1026ef969cae897efbd76d
Author: Soumya Koduri <skoduri>
Date:   Wed Oct 4 14:34:48 2017 +0530

    gfapi: set lkowner in glfd
    
    We need a provision to be able to set lkowner (which is
    used to distinguish locks maintained by server) in gfapi.
    Since the same lk_owner need to be used to be able to
    flush the lock while closing the fd, store the lkowner
    in the glfd structure itself.
    
    A new API has been added to be able to set lkowner in glfd.
    
    Change-Id: I67591d6b9a89c20b9617d52616513ff9e6c06b47
    BUG: 1499641
    Signed-off-by: Soumya Koduri <skoduri>

Comment 6 Worker Ant 2017-10-13 14:52:51 UTC

REVIEW: https://review.gluster.org/18522 (gfapi: update symbol version of glfd_set_lkowner to 3.10.7) posted (#1) for review on master by soumya k (skoduri)

Comment 7 Worker Ant 2017-10-14 03:45:12 UTC

REVIEW: https://review.gluster.org/18522 (gfapi: update symbol version of glfd_set_lk_owner to 3.10.7) posted (#2) for review on master by soumya k (skoduri)

Comment 8 Worker Ant 2017-10-15 06:09:59 UTC

REVIEW: https://review.gluster.org/18522 (gfapi: update symbol version of glfd_set_lk_owner to 3.10.7) posted (#3) for review on master by soumya k (skoduri)

Comment 9 Worker Ant 2017-10-17 13:53:44 UTC

COMMIT: https://review.gluster.org/18522 committed in master by Niels de Vos (ndevos) 
------
commit 05b9dce1b503ab10efdb79a870b07d982cb5a823
Author: Soumya Koduri <skoduri>
Date:   Fri Oct 13 20:15:55 2017 +0530

    gfapi: update symbol version of glfd_set_lk_owner to 3.10.7
    
    To be able to backport the API glfd_set_lk_owner() to
    existing stable (3.10, 3.12) releases, change its symbol
    version to 3.10.7 (upcoming 3.10 release).
    
    Also sticking to the norms of the gfapi library, changing
    the routine name to glfs_fd_set_lkowner()
    
    BUG: 1499641
    Change-Id: I43d002a24f493770a3daa774dbda2b7ea6d49e37
    Signed-off-by: Soumya Koduri <skoduri>

Comment 10 Shyamsundar 2017-12-08 17:43:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/