Bug 1500082

Summary:	[RFE] Support value-source option for node attribute rule expressions
Product:	Red Hat Enterprise Linux 8	Reporter:	Ken Gaillot <kgaillot>
Component:	pcs	Assignee:	Tomas Jelinek <tojeline>
Status:	CLOSED WONTFIX	QA Contact:	cluster-qe <cluster-qe>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.0	CC:	cfeist, cluster-maint, idevat, mlisik, mpospisi, omular, tojeline
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-12-01 07:29:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ken Gaillot 2017-10-09 20:15:06 UTC

Description of problem: The Pacemaker version in RHEL 7.5 will support the new "value-source" option, but pcs does not yet support it.


Version-Release number of selected component (if applicable): 7.5

Additional info: value-source in a rule expression allows a node attribute to be compared against a resource parameter or meta-attribute, rather than a literal string. Upstream documentation is available at:

http://clusterlabs.org/doc/en-US/Pacemaker/1.1-pcs/html-single/Pacemaker_Explained/index.html#_node_attribute_expressions

Comment 2 Tomas Jelinek 2017-10-10 07:25:48 UTC

If I get this right, we need to update the rule parser. Currently, it supports the following syntax:
<attribute> lt|gt|lte|gte|eq|ne [string|integer|version] <value>
and we need to extend this in a way users can specify source of the value, i.e. something like this:
<attribute> lt|gt|lte|gte|eq|ne [literal|param|meta] [string|integer|version] <value>
This, however, applies only to rules used in location constraints.

Also, it might be worth change the documentation to this:
<attribute> lt|gt|lte|gte|eq|ne [<value-source>] [<value-type>] <value>
value-source can be: literal, param or meta; literal being the default
value-type can be: string, integer or version; string being the default

Comment 4 Ken Gaillot 2017-10-11 16:12:29 UTC

Comment 2 sounds good

Comment 8 RHEL Program Management 2020-12-01 07:29:38 UTC

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.