Bug 1500090

Summary: paged list on repo discovery shows too many per page
Product: Red Hat Satellite Reporter: Tom McKay <tomckay>
Component: Content ManagementAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Jameer Pathan <jpathan>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.2.0CC: bbuckingham, cwelton, jyejare, pcreech, rohoover, sgraessl, tomckay
Target Milestone: 6.4.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-16 19:15:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Products discovered repos page
none
Products discovered repos page Pagination none

Description Tom McKay 2017-10-09 20:48:49 UTC
To reproduce, go to repo discovery on products page. Note that there are five empty rows (should be no rows). Try discovering docker type at registry.access.redhat.com . Note that the results are not paged. List filter should update count of objects and be paged as well.

Comment 1 Tom McKay 2017-10-09 20:48:55 UTC
Created from redmine issue http://projects.theforeman.org/issues/21258

Comment 2 Tom McKay 2017-10-09 20:49:00 UTC
Upstream bug assigned to None

Comment 6 Satellite Program 2017-10-12 16:00:35 UTC
Upstream bug assigned to walden

Comment 7 Satellite Program 2017-10-19 18:00:35 UTC
Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/21258 has been resolved.

Comment 8 Roxanne Hoover 2018-06-22 14:04:46 UTC
Created attachment 1453738 [details]
Products discovered repos page

Comment 9 Roxanne Hoover 2018-06-22 14:06:09 UTC
Reproduced via instructions.

Tested on SNAP 8.

Issue 1:
Note that there are five empty rows (should be no rows).

FIXED

Issue 2: 
Note that the results are not paged. List filter should update count of objects and be paged as well.

NOT FIXED

Screens attached.

Comment 10 Roxanne Hoover 2018-06-22 14:06:37 UTC
Created attachment 1453739 [details]
Products discovered repos page Pagination

Comment 11 Walden Raines 2018-06-28 16:18:42 UTC
The foreman tasks bulk search api itself does not support pagination and I don't have enough rails expertise to add a new feature to the bulk search API supporting pagination.  This should likely be an RFE to foreman tasks rather than a bug on the UI of this page as the UI can only work with what is given to it.

Thoughts on this Tom and Rox?

Comment 12 Walden Raines 2018-06-28 16:22:53 UTC
Also note that the PR itself (https://github.com/Katello/katello/pull/7013) simply removed the pagination from the page because the foreman bulk search API doesn't support pagination.  So I question if FailedQA is accurate in this case.

Comment 13 Corey Welton 2018-06-28 19:20:06 UTC
If the bug was triaged in as to be fixed, per the description, I'm of the opinion that it needs to be fixed/repaired to spec. 

I agree with the assessment that it is perhaps an RFE; I further recognize that the initial report is perhaps two separate issues and perhaps should be/should've been filed as such. 

That said, the filed issue, accepted by the triage team, did note pagination in the report.

We may be able to remedy this by filing a separate issues for the lack of pagination and triage the issue accordingly. As it exists right now, however, the issue is not resolved as it is written.

Comment 14 Walden Raines 2018-06-28 22:19:30 UTC
(In reply to Corey Welton from comment #13)
> If the bug was triaged in as to be fixed, per the description, I'm of the
> opinion that it needs to be fixed/repaired to spec. 
> 
> I agree with the assessment that it is perhaps an RFE; I further recognize
> that the initial report is perhaps two separate issues and perhaps should
> be/should've been filed as such. 
> 
> That said, the filed issue, accepted by the triage team, did note pagination
> in the report.
> 
> We may be able to remedy this by filing a separate issues for the lack of
> pagination and triage the issue accordingly. As it exists right now,
> however, the issue is not resolved as it is written.

That's fine by me.

Comment 15 Satellite Program 2018-06-29 00:00:35 UTC
Upstream bug assigned to walden

Comment 16 Tom McKay 2018-07-05 17:24:32 UTC
+1 to make pagination a separate low priority issue

Comment 17 Brad Buckingham 2018-07-05 19:31:00 UTC
I am going to re-associate the original redmine issue as it is addressing 'Issue 1'.  It should not have been removed.

Based on discussion with Tom and Jake in IRC, I have created a bug 1598555 to track 'Issue 2'.  That behavior is an RFE and is not required for beta.

I am also going to place this back in to POST.

If there are any concerns, please let me know. Thanks All!

Comment 18 Jameer Pathan 2018-08-01 13:34:06 UTC
VERIFIED 

@satellite 6.4 snap 14

Steps:

1. go to Content -> Products
2. click Repo Discovery
3. select Repository Type - 'Container Images'
4. enter Registry to Discover - 'registry.access.redhat.com'
5. click Discover

observation:

- No empty rows found on page Content -> Products -> Repository Discovery


Note: 
- Regarding Pagination issue there is a low priority bug 1598555 created for it.

Comment 19 Bryan Kearney 2018-10-16 19:15:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:2927