Bug 1500649
| Summary: | Shellcheck errors in hook scripts | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Anoop C S <anoopcs> | ||||
| Component: | scripts | Assignee: | Anoop C S <anoopcs> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | mainline | CC: | bugs | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | glusterfs-v4.1.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-06-20 17:57:11 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
REVIEW: https://review.gluster.org/18485 (extras/hooks: Fix errors from shellcheck utility) posted (#1) for review on master by Anoop C S (anoopcs) REVIEW: https://review.gluster.org/18485 (extras/hooks: Fix errors reported via shellcheck utility) posted (#2) for review on master by Anoop C S (anoopcs) REVIEW: https://review.gluster.org/18485 (extras/hooks: Fix errors reported via shellcheck utility) posted (#3) for review on master by Anoop C S (anoopcs) COMMIT: https://review.gluster.org/18485 committed in master by Jeff Darcy (jeff.us) ------ commit 087703fae449b725ebd82bc3cd65763a016fb098 Author: Anoop C S <anoopcs> Date: Wed Oct 11 13:29:13 2017 +0530 extras/hooks: Fix errors reported via shellcheck utility Change-Id: I217c6b2a39955f1709bb3452b00d33c2dcb60faa BUG: 1500649 Signed-off-by: Anoop C S <anoopcs> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report. glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html [2] https://www.gluster.org/pipermail/gluster-users/ Re-opening this bug as we have more fixes coming down the line.. REVIEW: https://review.gluster.org/19181 (extras/hooks: Fix disabled-quota-root-xattr-heal.sh hook script) posted (#2) for review on master by Anoop C S REVIEW: https://review.gluster.org/19204 (Fix S30samba-start.sh hook script) posted (#3) for review on master by REVIEW: https://review.gluster.org/19181 (Fix disabled-quota-root-xattr-heal.sh hook script) posted (#4) for review on master by COMMIT: https://review.gluster.org/19181 committed in master by "Amar Tumballi" <amarts> with a commit message- Fix disabled-quota-root-xattr-heal.sh hook script Fixing all shellchek warnings and POSIX incomapatibilities Change-Id: I35772bfcf7344c6ed9bd2a7db300c8f58bd3b243 BUG: 1500649 Signed-off-by: Milan Zink <zeten30> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v4.1.0, please open a new bug report. glusterfs-v4.1.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://lists.gluster.org/pipermail/announce/2018-June/000102.html [2] https://www.gluster.org/pipermail/gluster-users/ |
Created attachment 1337064 [details] Shellcheck output Description of problem: Please see the attachment for the output on running Shellcheck utility against hook scripts inside GlusterFS code base. Version-Release number of selected component (if applicable): mainline How reproducible: Always Steps to Reproduce: 1. Clone GlusterFS repository 2. Find all .sh scripts under extras/hooks directory and run the utility against every such script. # for i in `find extras/hook-scripts/ -name "*.sh"`; do shellcheck $i; done Actual results: Errors are present in hook scripts as reported by Shellcheck Expected results: No errors should be reported.