Bug 1500849

Summary: [Embedded Ansible] Notification after adding invalid Repo does not reflect information about Failure, rather it says "Successfully Completed"
Product: Red Hat CloudForms Management Engine Reporter: Kedar Kulkarni <kkulkarn>
Component: ProvidersAssignee: James Wong <jwong>
Status: CLOSED NOTABUG QA Contact: Dave Johnson <dajohnso>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 5.9.0CC: gblomqui, hkataria, jfrey, jhardy, kkulkarn, lcouzens, mpovolny, obarenbo, pakotvan
Target Milestone: GAFlags: kkulkarn: automate_bug-
Target Release: cfme-future   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: ansible_embed
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-11 20:17:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: Bug
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Ansible Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot none

Description Kedar Kulkarni 2017-10-11 15:15:00 UTC 
Created attachment 1337273 [details]
Screenshot

Description of problem:
Please see screenshot attached, the Message displayed for when I added an INVALID repo (http://test), which ended up failing. So, 1st thing that I expect is to see a Message telling me the repo addition "Failed" with the Red Cross mark. Not expecting to see Green Check mark. 

On the other hand, the message is incorrect, in that the text says "...Project Creation()..." where the () after creation are empty. When I added a valid repo later to see what should be there in those (), I saw there was "name=reponame" in that (). Which made that message look as follows: 
"... Project Creation(name=reponame)..."

So, I think if the () are empty, then message is incorrect. 

Lastly, is (manager_id=2) should be "2" for every repo I add? Because I added multiple repo and manager_id does not seem to change.



Version-Release number of selected component (if applicable):
5.9.0.1

100%

Steps to Reproduce:
1.Enable embedded Ansible Role on Appliance 
2.Go to Automate -> Ansible -> Repositories
3.Configuration-> Add new Repositories 
4.Add some random repository which will be invalid and would fail to add

Actual results:
See screenshot


Expected results:
Show "Red Cross" Icon in the pop-up notification to make sure the notifications brings users attention to fact that the repo addition failed. And provide correct "Error" Message.

Additional info:
Comment 3 Adam Grare 2017-10-11 17:52:27 UTC 
*** Bug 1494035 has been marked as a duplicate of this bug. ***
Comment 4 Adam Grare 2017-10-11 17:53:41 UTC 
James can you look at adding a notification when adding a repository fails?
Comment 6 Kedar Kulkarni 2017-10-11 18:19:58 UTC 
Dan, following BZ is created : https://bugzilla.redhat.com/show_bug.cgi?id=1500917
Comment 7 James Wong 2017-10-11 19:58:45 UTC 
Kedar,

This behavior is expected. Tower allows you to add a project using urls that don't represent valid repositories.

So the repo creation is successful and the notification correctly reflects that.

What fails later is Tower's repo refresh (i.e. Tower tries to retrieve playbooks from the said repo url).  And you can see that failure by checking on the repo's status. Can you confirm that?

regards,
james
Comment 8 Kedar Kulkarni 2017-10-11 20:05:48 UTC 
James, 

Yes, I can see that repo status is "failed". But then it goes back to original BZ[1], as the status is failed, can we get the notification for that? According to Zita in [1], we should see a Notification for that. 

Hope that makes sense.

Thanks,
KK.

[1]https://bugzilla.redhat.com/show_bug.cgi?id=1471868
Comment 9 James Wong 2017-10-11 20:17:05 UTC 
Hi Kedar,

Currently, the status of Tower's repo/playbook refresh will only be updated and no alert/notification is being generated for a failure.

It will be new feature to achieve that.

regards,
James


PS. Since this is not a bug, I'm closing it.