Bug 1500958
| Summary: | Review Request: python-kiwi-gtk - Framework for Python GUI applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Haïkel Guémar <karlthered> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | karlthered, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-03-30 12:52:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1483339 | ||
|
Description
Haïkel Guémar
2017-10-11 20:45:39 UTC
The spec looks good, but here's a thought for upgrade paths: 1. Change reverse dependency of kiwi-gtk (flumotion) to the new name for the dependency 2. New python2-kiwi will have Conflicts with python2-kiwi and python-kiwi < 8.00 3. New python2-kiwi will have Conflicts with flumotion <= ver-rel that requires python-kiwi. Does that work for you? Also, as a note, it looks like the python2-kiwi-gtk subpackage is a noarch package? So it should have "BuildArch: noarch", right? > 2. New python2-kiwi will have Conflicts with python2-kiwi and python-kiwi < 8.00
It will also have a conflicts of "python2-kiwi-gtk" to codify the folder conflict.
Any feedback? Ack for suggestion, I'll push a newer version of the spec this week (should be ready but haven't finished to test it) Spec URL: https://hguemar.fedorapeople.org/reviews/python-kiwi-gtk.spec SRPM URL: https://hguemar.fedorapeople.org/reviews/python-kiwi-gtk-1.11.1-1.fc28.src.rpm Looks good to me. Please make sure to change flumotion as noted in Comment 1 after completing the rename. This will require special attention by releng, because the git repository needs to be renamed instead of you getting a new repository, otherwise I can't use python-kiwi still. The same would probably go for its counterpart in Koji... I'll fix flumotion at the same time as provenpackager. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-kiwi-gtk (In reply to Haïkel Guémar from comment #10) > I'll fix flumotion at the same time as provenpackager. Can you please get this package imported and make the necessary adjustments in f28 and rawhide? python-kiwi-gtk-1.11.1-1.fc28 flumotion-0.11.0.1-9.20140103git886031a.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-83f7373a17 flumotion-0.11.0.1-9.20140103git886031a.fc28, python-kiwi-gtk-1.11.1-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-83f7373a17 flumotion-0.11.0.1-9.20140103git886031a.fc28, python-kiwi-gtk-1.11.1-1.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |