Bug 1501022

Summary:	Make choose-local configurable through `volume-set` command
Product:	[Community] GlusterFS	Reporter:	Krutika Dhananjay <kdhananj>
Component:	replicate	Assignee:	Krutika Dhananjay <kdhananj>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-glusterfs-3.12.2	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1480525	Environment:
Last Closed:	2017-10-13 12:47:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1480525, 1501023
Bug Blocks:

Description Krutika Dhananjay 2017-10-12 04:18:30 UTC

+++ This bug was initially created as a clone of Bug #1480525 +++

Description of problem:

Same as summary. There is no 'reconfigure' code for choose-local currently.

Version-Release number of selected component (if applicable):


How reproducible:

Found this as part of doing some perf experiments with random-read in ovirt-gluster setup.

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Worker Ant on 2017-08-11 06:19:46 EDT ---

REVIEW: https://review.gluster.org/18026 (cluster/afr: Make choose-local "reconfigurable") posted (#1) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Worker Ant on 2017-08-18 05:14:10 EDT ---

REVIEW: https://review.gluster.org/18026 (cluster/afr: Make choose-local "reconfigurable") posted (#2) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Worker Ant on 2017-09-20 08:27:01 EDT ---

REVIEW: https://review.gluster.org/18026 (cluster/afr: Make choose-local "reconfigurable") posted (#3) for review on master by Krutika Dhananjay (kdhananj)

--- Additional comment from Worker Ant on 2017-09-29 22:15:26 EDT ---

COMMIT: https://review.gluster.org/18026 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 1e2d6537875d16b783e3c50ada7ee61487c6d796
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Aug 11 15:43:58 2017 +0530

    cluster/afr: Make choose-local "reconfigurable"
    
    With this change, enabling choose-local (which means its state makes
    transition from "off" to "on") will be effective after the first
    gfid-lookup on "/" since volume-set was executed.
    
    Change-Id: Ibab292ba705d993b475cd0303fb3318211fb2500
    BUG: 1480525
    Signed-off-by: Krutika Dhananjay <kdhananj>

Comment 1 Worker Ant 2017-10-12 04:23:27 UTC

REVIEW: https://review.gluster.org/18495 (cluster/afr: Make choose-local "reconfigurable") posted (#1) for review on release-3.12 by Krutika Dhananjay (kdhananj)

Comment 2 Worker Ant 2017-10-12 18:46:15 UTC

COMMIT: https://review.gluster.org/18495 committed in release-3.12 by jiffin tony Thottan (jthottan) 
------
commit ff86417be4046575e0eb648fb3a47274aaf18ecd
Author: Krutika Dhananjay <kdhananj>
Date:   Fri Aug 11 15:43:58 2017 +0530

    cluster/afr: Make choose-local "reconfigurable"
    
            Backport of:
            > Change-Id: Ibab292ba705d993b475cd0303fb3318211fb2500
            > Reviewed-on: https://review.gluster.org/18026
            > BUG: 1480525
            > cherry-picked from commit 1e2d6537875d16b783e3c50ada7ee61487c6d796
    
    With this change, enabling choose-local (which means its state makes
    transition from "off" to "on") will be effective after the first
    gfid-lookup on "/" since volume-set was executed.
    
    Change-Id: Ibab292ba705d993b475cd0303fb3318211fb2500
    BUG: 1501022
    Signed-off-by: Krutika Dhananjay <kdhananj>

Comment 3 Jiffin 2017-10-13 12:47:53 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.2, please open a new bug report.

glusterfs-glusterfs-3.12.2 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-October/032684.html
[2] https://www.gluster.org/pipermail/gluster-users/