Bug 1501064

Summary: 'register' missing from usage and epilog parts of vdsm-tool register help message.
Product: Red Hat Enterprise Virtualization Manager Reporter: Wei Wang <weiwang>
Component: vdsmAssignee: Douglas Schilling Landgraf <dougsland>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.2.0CC: bazulay, cshao, danken, dguo, huzhao, jiawu, lsurette, qiyuan, rbarry, rhv-bugzilla-bot, srevivo, weiwang, yaniwang, ycui, yisong, ykaul, yzhao
Target Milestone: ovirt-4.2.0   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-12-07 02:47:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logfile none

Description Wei Wang 2017-10-12 06:20:52 UTC
Description of problem:
%(prog)s displays wrong in usage and epilog parts of vdsm-tool register help message.

[root@dell-per730-34 ~]# vdsm-tool register -h
usage: vdsm-tool [-h] [--node-address NODE_ADDRESS] [--node-name NODE_NAME]
                 --engine-fqdn ENGINE_FQDN
                 [--engine-https-port ENGINE_HTTPS_PORT] [--ssh-user SSH_USER]
                 [--ssh-port SSH_PORT] [--check-fqdn CHECK_FQDN]
                 [--fingerprint FINGERPRINT] [--vdsm-port VDSM_PORT]
                 [--vdsm-uuid VDSM_UUID]

Tool to register node to Engine

optional arguments:
  -h, --help            show this help message and exit
  --node-address NODE_ADDRESS
                        Define node FQDN or IP address. If not provided, will be used system host name
  --node-name NODE_NAME
                        Define node name. If not provided, will be used system short host name (the name before the first dot in the system host name)
  --engine-fqdn ENGINE_FQDN
                        Engine FQDN or IP address (See also: --check-fqdn)
  --engine-https-port ENGINE_HTTPS_PORT
                        Define engine https port. If not provided, will be used 443
  --ssh-user SSH_USER   SSH username to establish the connection with Engine. If not provided, the user which is executing the script will catch and used
  --ssh-port SSH_PORT   SSH port to establish the connection with Engine If not provided, the script will use the default SSH port 22
  --check-fqdn CHECK_FQDN
                        Disable or Enable FQDN check for Engine CA, this option is enabled by default (Use: True or False)
  --fingerprint FINGERPRINT
                        Specify an existing fingerprint to be validated against Engine CA fingerprint
  --vdsm-port VDSM_PORT
                        Specify the listen port of VDSM If not provided, will be used the default 54321
  --vdsm-uuid VDSM_UUID
                        Provide host UUID to be used instead vdsm.utils Useful for hosts with blank or buggy DMI

Example of use:
vdsm-tool --engine-fqdn engine.mydomain


Version-Release number of selected component (if applicable):
redhat-virtualization-host-4.2-20171011.2
vdsm-4.20.3-1.el7ev.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Clean install redhat-virtualization-host-4.2-20171011.2
2. Check help message of vdsm-tool register
   # vdsm-tool register -h


Actual results:
%(prog)s displays wrong as "vdsm-tool" in usage and epilog parts.


Expected results:
%(prog)s should be displayed as "vdsm-tool register" in usage and epilog parts.


Additional info:

Comment 1 Wei Wang 2017-10-12 06:24:03 UTC
Created attachment 1337538 [details]
logfile

Comment 2 Dan Kenigsberg 2017-10-12 11:05:49 UTC
Wei Wang, may I ask why you're testing this? Do you have use for vdsm-tool register these days?

Comment 3 Wei Wang 2017-10-13 01:47:05 UTC
(In reply to Dan Kenigsberg from comment #2)
> Wei Wang, may I ask why you're testing this? Do you have use for vdsm-tool
> register these days?

Vdsm-tool register is an important feature for RHVH. It makes customer register RHVH to RHVM which is like the legacy rhvh. So I try it. I only tried to use vdsm-tool register yesterday.

Comment 4 Dan Kenigsberg 2017-10-13 07:13:15 UTC
(In reply to Wei Wang from comment #3)
> (In reply to Dan Kenigsberg from comment #2)
> > Wei Wang, may I ask why you're testing this? Do you have use for vdsm-tool
> > register these days?
> 
> Vdsm-tool register is an important feature for RHVH. 

I'm happy to hear that. I thought I'm the only one liking `vdsm-tool register`. I wonder, would it be helpful for customers to trigger it from cockpit?

Comment 5 Yaniv Kaul 2017-10-13 07:53:22 UTC
(In reply to Dan Kenigsberg from comment #4)
> (In reply to Wei Wang from comment #3)
> > (In reply to Dan Kenigsberg from comment #2)
> > > Wei Wang, may I ask why you're testing this? Do you have use for vdsm-tool
> > > register these days?
> > 
> > Vdsm-tool register is an important feature for RHVH. 
> 
> I'm happy to hear that. I thought I'm the only one liking `vdsm-tool
> register`. I wonder, would it be helpful for customers to trigger it from
> cockpit?

I was under the impression we deprecated the register flow?

Comment 6 Ryan Barry 2017-10-13 11:25:29 UTC
We've never used this from cockpit on NGN.

In my opinion, there's no use to this -- if you know the address of the host, adding from RHVM is nicer than logging into cockpit to do the reverse

Comment 7 RHV bug bot 2017-12-06 15:44:37 UTC
Gil, can you give qa_ack please so this can go into the ET?

Comment 8 RHV bug bot 2017-12-06 16:18:58 UTC
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.2-ga': '?'}', ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.2-ga': '?'}', ]

For more info please contact: rhv-devops

Comment 9 Gil Klein 2017-12-06 16:43:41 UTC
(In reply to RHV Bugzilla Automation and Verification Bot from comment #7)
> Gil, can you give qa_ack please so this can go into the ET?
Ying, could you please handle this request?

Comment 10 cshao 2017-12-07 02:47:14 UTC
After confirmed with DEV and PM, we don't need cover this scenario in RHV 4.2 phase, so close this bug.