Bug 1501317

Summary:	glusterfs fails to build twice in a row
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	build	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.13.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1494527	Environment:
Last Closed:	2017-12-08 17:43:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1494527

Description Niels de Vos 2017-10-12 11:15:20 UTC

+++ This bug was initially created as a clone of Bug #1494527 +++

Description of problem:


Packages should be able to build twice in a row, so that make clean targets make the original source realy clean again.


How reproducible:
Build it twice in a row

Currently in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876359 it is reported that it fails with:

There are at least .pyc files left around:

  libglusterfs/src/generator.pyc

generated XDR symlinks:

  rpc/xdr/gen/*.x

and unexpected modifications to shipped files:

   tests/basic/fuse/Makefile
   tests/basic/gfapi/Makefile

After all those are removed, the build still fails due to the missing
Makefile.in files that have been removed somewhere. Running:

  $ autoreconf -f -i

makes things worse as then we get tons of modified Makefile.in file
changes.  I've not looked further after this.

Comment 1 Worker Ant 2017-10-12 11:16:05 UTC

REVIEW: https://review.gluster.org/18505 (build: make it possible to build cleanly 2x in a row) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 2 Worker Ant 2017-10-13 16:28:59 UTC

COMMIT: https://review.gluster.org/18505 committed in master by Jeff Darcy (jeff.us) 
------
commit a413c6353dbfff5221ea020ff8e1475d5ee17a81
Author: Niels de Vos <ndevos>
Date:   Tue Oct 10 13:23:50 2017 +0200

    build: make it possible to build cleanly 2x in a row
    
    'make clean' does not cleanup everything, and some of the files get
    cleaned too eagerly. Several files are being packaged in a 'make dist'
    tarball, that get rebuild each time anyway.
    
    Specifically, this change prevents
     - libglusterfs/src/generator.pyc from laying around
     - keeping rpc/xdr/gen/*.x symlinks
     - modifying tests/basic/{fuse,gfapi}/Makefile each run
     - including tests/env.rc and events/src/eventtypes.py in the tarball
    
    Change-Id: I774dd1abf3a9d3b6a89b938cf6ee7d7792c59a82
    BUG: 1501317
    Reported-by: Patrick Matthäi <pmatthaei>
    Signed-off-by: Niels de Vos <ndevos>

Comment 3 Shyamsundar 2017-12-08 17:43:44 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.13.0, please open a new bug report.

glusterfs-3.13.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/announce/2017-December/000087.html
[2] https://www.gluster.org/pipermail/gluster-users/