Bug 1501794

Summary: [7.4-ALT]: SEEK_HOLE/SEEK_DATA with a negative file offset test fails
Product: Red Hat Enterprise Linux 7 Reporter: Zorro Lang <zlang>
Component: kernel-altAssignee: Bill O'Donnell <billodo>
kernel-alt sub component: XFS QA Contact: Zorro Lang <zlang>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: medium CC: bfoster, billodo, bugproxy, hannsj_uhl, hkrzesin, jkachuck, xzhou
Version: 7.4-Alt   
Target Milestone: rc   
Target Release: 7.5-Alt   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: kernel-alt-4.14.0-0.rc7.1.el7a Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 05:39:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1476742, 1522983    
Attachments:
Description Flags
dmesg none

Description Zorro Lang 2017-10-13 08:38:05 UTC 
Description of problem:
xfstests generic/448 fails on XFS, it tests negative SEEK_HOLE/SEEK_DATA offset.  Ext4 has fixed this bug on bug 1494423. Then upstream found and fixed this bug later. I think below patch maybe help.

commit d6ab17f261919d212ec0a9e33d01f46df0ec1fde
Author: Darrick J. Wong <darrick.wong>
Date:   Wed Jul 12 10:26:47 2017 -0700

    vfs: in iomap seek_{hole,data}, return -ENXIO for negative offsets

Version-Release number of selected component (if applicable):
kernel-4.11.0-42.el7a

How reproducible:
100%

Steps to Reproduce:
run xfstests generic/448 on XFS

Actual results:
# cat results/generic/448.full 
File system magic#: 0x58465342
Allocation size: 4096

18. Test file with negative SEEK_{HOLE,DATA} offsets  
18.01 SEEK_HOLE expected -1 or -1, got 0.                         FAIL
18.02 SEEK_DATA expected -1 with errno -6, got -1.                FAIL

seek sanity check failed!

Expected results:
Test pass

Additional info:
This bug is not so urgent, and Pegas-1.0 is goint to be released, so I think fix it on "rhel-7.5-alt" is fine. Feel feel to change it to pages-1.0 if devel would like to do that.
Comment 1 Brian Foster 2017-10-16 13:53:04 UTC 
*** Bug 1502483 has been marked as a duplicate of this bug. ***
Comment 2 IBM Bug Proxy 2017-10-16 14:20:26 UTC 
Created attachment 1339252 [details]
dmesg
Comment 6 IBM Bug Proxy 2017-11-22 07:10:45 UTC 
------- Comment From mainamdar.com 2017-11-22 02:03 EDT-------
*** Bug 159723 has been marked as a duplicate of this bug. ***
Comment 7 IBM Bug Proxy 2017-12-08 09:20:49 UTC 
------- Comment From hasriram.com 2017-12-08 04:15 EDT-------
Test passed with kernel 4.14.0-6.el7a.ppc64le.

# ./check tests/generic/448
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/ppc64le ltc-boston27 4.14.0-6.el7a.ppc64le
MKFS_OPTIONS  -- -f -bsize=4096 /dev/loop2
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/loop2 /home/scratch

generic/448	 0s
Ran: generic/448
Passed all 1 tests

Thanks,
Harish
Comment 8 Zorro Lang 2018-01-16 10:24:37 UTC 
generic/448 test passed on ext2/3/4 and XFS of RHEL-ALT-7.5 with kernel-4.14.0-24.el7a.aarch64.debug. And thanks the verification from IBM (comment 7)
Comment 11 errata-xmlrpc 2018-04-10 05:39:47 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0654