Bug 1501956

Summary:	gfapi: API needed to set lk_owner
Product:	[Community] GlusterFS	Reporter:	Soumya Koduri <skoduri>
Component:	libgfapi	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	bugs <bugs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.12	CC:	bugs, ndevos
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-glusterfs-3.12.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1499641	Environment:
Last Closed:	2017-11-29 05:52:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1499641
Bug Blocks:	1500704

Description Soumya Koduri 2017-10-13 14:58:18 UTC

+++ This bug was initially created as a clone of Bug #1499641 +++

Description of problem:

Glusterfs server differentiates locks based on both client-id and lock owner. There is no provision to set lk_owner as of now via gfapi. Hence a new API is needed to set the same. Since the lk_owner is associated with a particular glfd (until we get mandatory lk support), the API definition looks like below -

"glfd_set_lk_owner()"


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Soumya Koduri on 2017-10-09 03:34:27 EDT ---

https://review.gluster.org/#/c/18429

--- Additional comment from Worker Ant on 2017-10-09 06:06:12 EDT ---

REVIEW: https://review.gluster.org/18429 (gfapi: set lkowner in glfd) posted (#3) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2017-10-10 07:57:54 EDT ---

REVIEW: https://review.gluster.org/18429 (gfapi: set lkowner in glfd) posted (#4) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2017-10-12 06:42:51 EDT ---

REVIEW: https://review.gluster.org/18429 (gfapi: set lkowner in glfd) posted (#5) for review on master by soumya k (skoduri)

--- Additional comment from Worker Ant on 2017-10-13 03:48:04 EDT ---

COMMIT: https://review.gluster.org/18429 committed in master by Niels de Vos (ndevos) 
------
commit c22cec3928be6924fb1026ef969cae897efbd76d
Author: Soumya Koduri <skoduri>
Date:   Wed Oct 4 14:34:48 2017 +0530

    gfapi: set lkowner in glfd
    
    We need a provision to be able to set lkowner (which is
    used to distinguish locks maintained by server) in gfapi.
    Since the same lk_owner need to be used to be able to
    flush the lock while closing the fd, store the lkowner
    in the glfd structure itself.
    
    A new API has been added to be able to set lkowner in glfd.
    
    Change-Id: I67591d6b9a89c20b9617d52616513ff9e6c06b47
    BUG: 1499641
    Signed-off-by: Soumya Koduri <skoduri>

--- Additional comment from Worker Ant on 2017-10-13 10:52:51 EDT ---

REVIEW: https://review.gluster.org/18522 (gfapi: update symbol version of glfd_set_lkowner to 3.10.7) posted (#1) for review on master by soumya k (skoduri)

Comment 1 Worker Ant 2017-10-13 15:28:41 UTC

REVIEW: https://review.gluster.org/18524 (gfapi: set lkowner in glfd) posted (#1) for review on release-3.12 by soumya k (skoduri)

Comment 2 Worker Ant 2017-10-17 11:03:17 UTC

REVIEW: https://review.gluster.org/18524 (gfapi: set lkowner in glfd) posted (#2) for review on release-3.12 by soumya k (skoduri)

Comment 3 Worker Ant 2017-10-25 11:33:43 UTC

COMMIT: https://review.gluster.org/18524 committed in release-3.12 by jiffin tony Thottan (jthottan) 
------
commit 19fe3906c13ad360c07bb94db6b7f63024b30ef1
Author: Soumya Koduri <skoduri>
Date:   Tue Oct 17 16:12:06 2017 +0530

    gfapi: set lkowner in glfd
    
    We need a provision to be able to set lkowner (which is
    used to distinguish locks maintained by server) in gfapi.
    Since the same lk_owner need to be used to be able to
    flush the lock while closing the fd, store the lkowner
    in the glfd structure itself.
    
    A new API has been added to be able to set lkowner in glfd.
    
    This is backport of below mainline fix -
     https://review.gluster.org/#/c/18429
     https://review.gluster.org/#/c/18522/
    
    Change-Id: I67591d6b9a89c20b9617d52616513ff9e6c06b47
    BUG: 1501956
    Signed-off-by: Soumya Koduri <skoduri>

Comment 4 Jiffin 2017-11-29 05:52:32 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-glusterfs-3.12.3, please open a new bug report.

glusterfs-glusterfs-3.12.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-devel/2017-November/053983.html
[2] https://www.gluster.org/pipermail/gluster-users/