Bug 150213

Summary:	local variable used before set
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	silky	Assignee:	Toni Willberg <toniw>
Status:	CLOSED NEXTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-03-03 20:23:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-03-03 19:51:34 UTC

Description of problem:

I just tried to compile silky-0.5.2-1 from 
Redhat Fedora Extras development tree.

The Intel compiler said

support.c(85): remark #592: variable "iter" is used before its value
is set

The source code is

  GtkTreeIter iter;
  gboolean valid;
  SilcClientID *stored_clientid;

  debug("get_nicklist_iter_by_clientid()");

  if (!client_id) {
    debug("Did not get client_id");
    return iter;

Suggest init local variable iter before first use.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Toni Willberg 2005-03-03 20:23:56 UTC

Hi and thanks for the report.

The bug had been already fixed in the upstream CVS.

Next release of Silky containing the fix shall be released soon. We
are already in string freeze for release candidate.

Yours,
 Toni Willberg
 author of Silky