Bug 1502200
Summary: | Review Request: ghc-hxt - A collection of tools for processing XML with Haskell | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | haskell-devel, package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | ghc-hxt-9.3.1.16-1.fc28 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-12-12 11:16:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1491632, 1498400, 1498410 | ||
Bug Blocks: | 1511911 |
Description
Jens Petersen
2017-10-15 07:13:44 UTC
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22452288 Needed for skylighting for current pandoc You should split the doc in a subpackage: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4659200 bytes in 256 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation I appreciate > 4MB is significant - on the other hand the devel package footprint is about 55MB, so it is not that bad. I prefer not to subpackage haddocks in Fedora for now until we have good process in place to handle that. Another alternative could even be not to ship them though I think they are nice to have for offline usage. Well the right thing to do first is probably Provide: ghc-*-doc in all devel packages and then BR: ghc-*-doc in addition to ghc-*-devel deps. Then we can consider moving them to a separate package more easily. See also bug 1149850 The other downside to introducing this is we basically have to fork all the spec one time, since backporting this to current releases will be too much work, but okay it is just a one-time thing so I guess we can live with it. Anyway should this discussion to that bug or upstream... > Well the right thing to do first is probably Provide: ghc-*-doc
in all devel packages and then BR: ghc-*-doc in addition to
ghc-*-devel deps. Then we can consider moving them to
a separate package more easily.
I don't understand why you are complicating this matter, why do you want to apply it to *all* ghc packages? It just applies to ones with large doc, no need to add a BR either, the user will choose to install the doc subpackage or not.
(In reply to Robert-André Mauchin from comment #7) > I don't understand why you are complicating this matter, why do you want to > apply it to *all* ghc packages? It just applies to ones with large doc, no > need to add a BR either, the user will choose to install the doc subpackage > or not. Because it affects cross-referencing in haddock documentation. If the docs for deps are missing then it affects the haddock generation. AFAIK anyway. O then keep the docs in the main package. Okay, thanks for the review! Let's revisit the docs subpackaging again later. For F28 I want to at least add Provides. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-hxt. You may commit to the branch "f27" in about 10 minutes. Koji won't let me build for f28 yet. ghc-hxt-9.3.1.16-1.fc27, ghc-skylighting-0.1.1.5-3.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-f062f93498 ghc-hxt-9.3.1.16-1.fc27, ghc-skylighting-0.1.1.5-3.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |