Bug 1502551

Summary: files in {{ __tsb_files_location }} doesn't existing
Product: OpenShift Container Platform Reporter: Wenkai Shi <weshi>
Component: InstallerAssignee: ewolinet
Status: CLOSED ERRATA QA Contact: Wenkai Shi <weshi>
Severity: high Docs Contact:
Priority: high    
Version: 3.7.0CC: aos-bugs, jokerman, mmccomas, weshi
Target Milestone: ---   
Target Release: 3.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-28 22:17:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Wenkai Shi 2017-10-16 08:28:47 UTC
Description of problem:
Install OCP with template_service_broker failed due to location {{ __tsb_files_location }} doesn't existing. 
According to [1] So far the location is
 [2], why not move to [3]?

[1]. /usr/share/ansible/openshift-ansible/roles/template_service_broker/vars/main.yml:__tsb_files_location: "../../../files/origin-components/"
[2]. /usr/share/ansible/openshift-ansible/
[3]. /usr/share/ansible/openshift-ansible/roles/template_service_broker/

Version-Release number of the following components:
openshift-ansible-3.7.0-0.153.0.git.0.d5028b3.el7
ansible-2.3.2.0-2.el7

How reproducible:
100%

Steps to Reproduce:
1. Install OCP with service_broker_install related parameters
2. 
3.

Actual results:
# ansible-playbook -i inventory -vvv /usr/share/ansible/openshift-ansible/playbooks/byo/config.yml
...
TASK [template_service_broker : copy] ********************************************************************************************************************************************************
task path: /usr/share/ansible/openshift-ansible/roles/template_service_broker/tasks/install.yml:24
failed: [master.example.com] (item=apiserver-template.yaml) => {
    "failed": true, 
    "item": "apiserver-template.yaml", 
    "msg": "Unable to find '../../../files/origin-components//apiserver-template.yaml' in expected paths."
}
failed: [master.example.com] (item=rbac-template.yaml) => {
    "failed": true, 
    "item": "rbac-template.yaml", 
    "msg": "Unable to find '../../../files/origin-components//rbac-template.yaml' in expected paths."
}
failed: [master.example.com] (item=template-service-broker-registration.yaml) => {
    "failed": true, 
    "item": "template-service-broker-registration.yaml", 
    "msg": "Unable to find '../../../files/origin-components//template-service-broker-registration.yaml' in expected paths."
}
...

Expected results:
Files should in expected paths.

Additional info:
[root@qe-weshi-ansible ~]# cd /usr/share/ansible/openshift-ansible/roles/template_service_broker/tasks/
[root@qe-weshi-ansible tasks]# ls ../../../files/origin-components/
ls: cannot access ../../../files/origin-components/: No such file or directory
[root@qe-weshi-ansible tasks]# cd ../../../;pwd
/usr/share/ansible/openshift-ansible
[root@qe-weshi-ansible openshift-ansible]# ls
library  playbooks  roles

Comment 1 ewolinet 2017-10-16 16:42:29 UTC
A little bit of backstory on the location: we will be syncing files from the origin repository to files/origin-components/ so to keep the job that sync's files over simple we would just copy to that top level directory. Hence those files not existing in the actual role.

It seems you're missing the top level 'files' directory. How did you pull down the openshift-ansible repository for installing? You should just need to ensure you're pulling down that missing 'files' directory as well.

Comment 2 Wenkai Shi 2017-10-17 01:51:02 UTC
(In reply to ewolinet from comment #1)
> A little bit of backstory on the location: we will be syncing files from the
> origin repository to files/origin-components/ so to keep the job that sync's
> files over simple we would just copy to that top level directory. Hence
> those files not existing in the actual role.
> 
> It seems you're missing the top level 'files' directory. How did you pull
> down the openshift-ansible repository for installing? You should just need
> to ensure you're pulling down that missing 'files' directory as well.

I pull down it by "yum install".

# yum install atomic-openshift-utils -y
# cd /usr/share/ansible/openshift-ansible/
# ls
library  playbooks  roles

Comment 3 Scott Dodson 2017-10-17 13:43:14 UTC
We need to add files directory to the openshift-ansible specfile.

Comment 7 Wenkai Shi 2017-10-25 03:10:06 UTC
Verified with version openshift-ansible-3.7.0-0.176.0.git.0.eec12b8.el7, the tsb_files existing in expected path, installer could pass TASK [template_service_broker : copy].

Comment 10 errata-xmlrpc 2017-11-28 22:17:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188