Bug 1502639

Summary:	Enable unit tests for libvirt-glib
Product:	[Fedora] Fedora	Reporter:	Marek Kašík <mkasik>
Component:	libvirt-glib	Assignee:	Daniel Berrangé <berrange>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	berrange, cfergeau, zeeshanak
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-glib-1.0.0-5.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-30 17:00:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marek Kašík 2017-10-16 11:33:09 UTC

libvirt-glib package has unit tests which can be evaluated as a part of build in koji. It is generally recommended to run these tests so that some problems can be cought soon enough before the package gets to the users.
Please, enable these tests in your package.
I can enable the tests for this package if you want and do the first build with them.

I've tested this package with local mock and the build passes as well as the tests (I will perform scratch build in Koji before pushing this change).

Comment 1 Christophe Fergeau 2017-10-16 13:04:49 UTC

Sure, would be great if you can enable them!

Comment 2 Daniel Berrangé 2017-10-16 13:06:05 UTC

NB, any spec file changes should be upstream first, or they're liable to be lost on next rebase.

Comment 3 Marek Kašík 2017-10-16 13:42:58 UTC

Thank you both, I'll prepare a patch and will post him to libvir-list then.

Comment 4 Marek Kašík 2017-10-30 17:00:11 UTC

The patch was accepted so I've pushed the same change to rawhide's spec file and done a new build of libvirt-glib.
Thanks.