Bug 1503176

Summary: Liquibase migration fails when activation keys referencing missing products exist
Product: [Community] Candlepin Reporter: Alex Wood <awood>
Component: candlepinAssignee: Alex Wood <awood>
Status: CLOSED CURRENTRELEASE QA Contact: Katello QA List <katello-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.2CC: afox, apatel, awood, bcourt, kgaikwad, ktordeur, redakkan, skallesh, tbrisker
Target Milestone: ---   
Target Release: 2.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: candlepin-2.3.1-1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1503177 1503179 (view as bug list) Environment:
Last Closed: 2019-04-04 13:22:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1503179    

Description Alex Wood 2017-10-17 13:39:45 UTC
Description of problem:

When migrating from 0.9.54 to 2.x, if a database has activation keys that are referencing products that have been deleted, the migration will fail.  The failure occurs in PerOrgsProductsMigrationTask due to the presence of the records in cp_activationkey_product that reference the missing products.

Version-Release number of selected component (if applicable): 2.x series

How reproducible: Always

Steps to Reproduce:
1. Starting with 0.9.54, create an activation key using a productId that does not exist.
2. Attempt to migrate to candlepin 2.0.

liquibase --driver=org.postgresql.Driver --classpath=/usr/share/java/postgresql-jdbc.jar:/var/lib/tomcat/webapps/candlepin/WEB-INF/classes/ --changeLogFile=db/changelog/changelog-update.xml --url=jdbc:postgresql:candlepin --username=candlepin  --password=<PASSWORD> migrate -Dcommunity=False

Actual results:

Liquibase update Failed: Migration failed for change set db/changelog/20150210094558-perorgproducts-phase-1.xml::20150210094558-35::crog:
     Reason: liquibase.exception.UnexpectedLiquibaseException: liquibase.exception.CustomChangeException: liquibase.exception.DatabaseException: One or more orgs failed data validation

Expected results:

Successful migration

Comment 1 Ivan Necas 2017-11-07 11:52:58 UTC
*** Bug 1510011 has been marked as a duplicate of this bug. ***

Comment 9 Kavita 2017-11-21 06:17:37 UTC
To add pre-upgrade check to detect if any bad content definition, created new BZ under Foreman-Maintain. This check will provide a step for user to delete bad content if any. 

Reference link - https://bugzilla.redhat.com/show_bug.cgi?id=1515614