Bug 1503363

Summary: sparse -Wbitwise flag does not work properly
Product: [Fedora] Fedora Reporter: Jacob Keller <jacob.e.keller>
Component: sparseAssignee: Jeff Layton <jlayton>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 26CC: jlayton
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: sparse-0.5.1-2.fc26 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-07 22:11:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
sparse srpm updated to master git tree none

Description Jacob Keller 2017-10-18 00:12:20 UTC
Description of problem:

The version of sparse installed by Fedora 26 (0.5.0-11) which is equivalent to 
v0.5.0-63-g82d573cb15e3 of the sparse git tree has a bug which enables -Wbitwise by default and does not honor "-Wno-bitwise" to disable the checks.

This was fixed upstream by 0dfda0d1f0fe ("make -Wbitwise operational again", 2017-02-18)

Version-Release number of selected component (if applicable): 0.5.0-11


How reproducible: Always


Steps to Reproduce:
1. Attempt to build something with sparse that has a bitwise warning, and disable the warning using -Wno-bitwise

Actual results:
The bitiwse warnings are always displayed regardless of whether -Wno-bitwise is added to the flags or not.


Expected results:
bitwise warnings are disabled and do not produce warning output when -Wno-bitwise is provided.

Additional info:
It seems that sparse has released v0.5.1 but has not published it in the usual place that the package expects to find new releases.

Comment 1 Jacob Keller 2017-10-18 00:38:00 UTC
Created attachment 1339940 [details]
sparse srpm updated to master git tree

I have an updated SRPM package which updates to the latest git tree of sparse, similar to how the previous update of 0.5.0-10 updated the tree.

Unfortunately 0.5.1 doesn't appear to have been officially released anywhere (it's not on the normal location on kernel.org...?) So this version still leaves it as 0.5.0-12

Comment 2 Jeff Layton 2017-10-18 15:57:58 UTC
Thanks for the heads up. I went ahead and updated the package to the new 0.5.1 release. This also cleans some old cruft out of the specfile's CFLAGS handling, though it relies on a small patch that I just sent upstream to the sparse maintainers.

In any case, the update request is available here for testing:

    https://koji.fedoraproject.org/koji/buildinfo?buildID=986382

Comment 3 Jacob Keller 2017-10-18 21:14:46 UTC
Out of curiosity, where is the 0.5.1 release hosted? It wasn't hosted in the same place as the previous 0.5.0 release.

Comment 5 Fedora Update System 2017-10-19 19:52:27 UTC
sparse-0.5.1-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c0a6847d8e

Comment 6 Jeff Layton 2017-10-25 10:51:50 UTC
The way that the makefile works, we were dropping some compiler flags that are needed when we passed in CFLAGS= on the make command line. The -2.fc26 package corrects the build.

Comment 7 Fedora Update System 2017-10-26 01:31:21 UTC
sparse-0.5.1-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-c0a6847d8e

Comment 8 Fedora Update System 2017-11-07 22:11:32 UTC
sparse-0.5.1-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.