Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Covscan detected the following in build iptables-1.4.21-23.el7:
1. Defect type: NO_EFFECT
1. iptables-1.4.21/extensions/libxt_recent.c:242: array_null: Comparing an array to null is not useful: "info->name", since the test will always evaluate as true.
2. iptables-1.4.21/extensions/libxt_recent.c:242: remediation: Was "info->name" formerly declared as a pointer?
# 240| if (info->check_set & XT_RECENT_TTL)
# 241| printf(" --rttl");
# 242|-> if(info->name) printf(" --name %s",info->name);
# 243|
# 244| switch(family) {
2. Defect type: NO_EFFECT
1. iptables-1.4.21/extensions/libxt_recent.c:202: array_null: Comparing an array to null is not useful: "info->name", since the test will always evaluate as true.
2. iptables-1.4.21/extensions/libxt_recent.c:202: remediation: Was "info->name" formerly declared as a pointer?
# 200| if (info->check_set & XT_RECENT_TTL)
# 201| printf(" TTL-Match");
# 202|-> if(info->name) printf(" name: %s", info->name);
# 203| if (info->side == XT_RECENT_SOURCE)
# 204| printf(" side: source");
Upstream accepted:
commit d0e3d95fa3442c6ff32f7fed3e0d2eeb2248ef9f
Author: Phil Sutter <phil>
Date: Fri Oct 20 13:24:36 2017 +0200
libxt_recent: Remove ineffective checks for info->name
In struct xt_recent_mtinfo{,_v1}, field 'name' is an array, not a
pointer. So there is no point in comparing it against NULL. Changing the
check to make sure it's content is not an empty string is pointless
either, since a non-empty default string is used and the argument parser
will refuse empty strings as --name argument. So simply get rid of the
checks altogether.
Signed-off-by: Phil Sutter <phil>
Signed-off-by: Florian Westphal <fw>
Covscan detected the following in build iptables-1.4.21-23.el7: 1. Defect type: NO_EFFECT 1. iptables-1.4.21/extensions/libxt_recent.c:242: array_null: Comparing an array to null is not useful: "info->name", since the test will always evaluate as true. 2. iptables-1.4.21/extensions/libxt_recent.c:242: remediation: Was "info->name" formerly declared as a pointer? # 240| if (info->check_set & XT_RECENT_TTL) # 241| printf(" --rttl"); # 242|-> if(info->name) printf(" --name %s",info->name); # 243| # 244| switch(family) { 2. Defect type: NO_EFFECT 1. iptables-1.4.21/extensions/libxt_recent.c:202: array_null: Comparing an array to null is not useful: "info->name", since the test will always evaluate as true. 2. iptables-1.4.21/extensions/libxt_recent.c:202: remediation: Was "info->name" formerly declared as a pointer? # 200| if (info->check_set & XT_RECENT_TTL) # 201| printf(" TTL-Match"); # 202|-> if(info->name) printf(" name: %s", info->name); # 203| if (info->side == XT_RECENT_SOURCE) # 204| printf(" side: source");