Bug 1505108

Summary: Review Request: petsc4py - This package provides Python bindings for MPI PETSc
Product: [Fedora] Fedora Reporter: Antonio T. (sagitter) <anto.trande>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-04 21:09:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Antonio T. (sagitter) 2017-10-22 10:14:46 UTC
Spec URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py.spec
SRPM URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py-3.7.0-1.20170629gitac769fc.fc26.src.rpm

Description:
This package provides Python bindings for PETSc,
the Portable, Extensible Toolkit for Scientific Computation.

Fedora Account System Username: sagitter

Comment 2 Antonio T. (sagitter) 2017-10-22 16:29:37 UTC
This package can be built on rawhide now.

Comment 3 Robert-André Mauchin 🐧 2017-10-23 15:53:51 UTC
Hello,

 - There's nothing there and the github owner doesn't seem to be involved with that project:

 URL:            https://github.com/luckydonald/%{pypi_name}

 - How did you pick the Git commit for the package? It seems to me that you should use ae3561094b56c26b423ef9a978f5cbc67b130e9b , cf: https://bitbucket.org/petsc/petsc4py/commits/tag/3.8.0

 - On a similar note, use git archive to package so we don't ship .git hidden files with the archive:

git clone https://bitbucket.org/petsc/petsc4py
cd petsc4py
git archive --format tar.gz --prefix petsc4py-3.8.0/ 3.8.0 > petsc4py-3.8.0.tar.gz

Comment 4 Antonio T. (sagitter) 2017-10-23 18:55:16 UTC
(In reply to Robert-André Mauchin from comment #3)
> Hello,
> 
>  - There's nothing there and the github owner doesn't seem to be involved
> with that project:
> 
>  URL:            https://github.com/luckydonald/%{pypi_name}

Fixed.

> 
>  - How did you pick the Git commit for the package? It seems to me that you
> should use ae3561094b56c26b423ef9a978f5cbc67b130e9b , cf:
> https://bitbucket.org/petsc/petsc4py/commits/tag/3.8.0
> 
>  - On a similar note, use git archive to package so we don't ship .git
> hidden files with the archive:
> 
> git clone https://bitbucket.org/petsc/petsc4py
> cd petsc4py
> git archive --format tar.gz --prefix petsc4py-3.8.0/ 3.8.0 >
> petsc4py-3.8.0.tar.gz

These are lines of an old release; petsc4py is now built from source archive 3.8.0 (https://bitbucket.org/petsc/petsc4py/downloads/).

Spec URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py.spec
SRPM URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py-3.8.0-1.fc26.src.rpm

Comment 5 Robert-André Mauchin 🐧 2017-10-24 10:58:38 UTC
https://github.com/petsc/petsc4py is returning 404 too.


These includes should probably go into -devel subpackages:

thon2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/numpy.h
python2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc.h
python2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python2-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.h

python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/numpy.h
python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc.h
python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python3-petsc4py-openmpi.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/openmpi/petsc4py/include/petsc4py/petsc4py.h

python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/numpy.h
python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc.h
python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python2-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.h

python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/numpy.h
python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc.h
python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.PETSc_api.h
python3-petsc4py-mpich.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python3.6/site-packages/mpich/petsc4py/include/petsc4py/petsc4py.h

Comment 6 Antonio T. (sagitter) 2017-10-24 17:50:06 UTC
> These includes should probably go into -devel subpackages:

I'm not totally sure, but i moved header files under directories expected by MPI guidelines.

Spec URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py.spec
SRPM URL: https://sagitter.fedorapeople.org/petsc4py/petsc4py-3.8.0-2.fc26.src.rpm

Comment 7 Robert-André Mauchin 🐧 2017-10-24 19:03:21 UTC
All ok for me, package accepted.

Comment 8 Gwyn Ciesla 2017-10-25 17:51:22 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/petsc4py

Comment 9 Fedora Update System 2017-10-26 12:59:39 UTC
petsc4py-3.8.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-71e07bfe33

Comment 10 Fedora Update System 2017-10-26 12:59:47 UTC
petsc4py-3.8.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e25c2f2615

Comment 11 Fedora Update System 2017-10-27 15:38:53 UTC
petsc4py-3.8.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-71e07bfe33

Comment 12 Fedora Update System 2017-10-27 18:49:09 UTC
petsc4py-3.8.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e25c2f2615

Comment 13 Fedora Update System 2017-11-04 21:09:07 UTC
petsc4py-3.8.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2017-11-11 03:06:32 UTC
petsc4py-3.8.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.