Bug 1505237

Summary:	Review Request: libell - Embedded Linux library
Product:	[Fedora] Fedora	Reporter:	Lubomir Rintel <lkundrak>
Component:	Package Review	Assignee:	Igor Gnatenko <ignatenko>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	25	CC:	package-review
Target Milestone:	---	Flags:	ignatenko: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-29 17:25:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lubomir Rintel 2017-10-23 06:28:30 UTC

SPEC: https://copr-be.cloud.fedoraproject.org/results/lkundrak/iwd/fedora-rawhide-x86_64/00648439-ell/ell.spec
SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/iwd/fedora-rawhide-x86_64/00648439-ell/ell-0.2-1.fc28.src.rpm
mock: https://copr-be.cloud.fedoraproject.org/results/lkundrak/iwd/fedora-rawhide-x86_64/00648439-ell/

Description:

The Embedded Linux* Library (ELL) provides core, low-level functionality for
system daemons. It typically has no dependencies other than the Linux kernel, C
standard library, and libdl (for dynamic linking). While ELL is designed to be
efficient and compact enough for use on embedded Linux platforms, it is not
limited to resource-constrained systems.

Comment 1 Igor Gnatenko 2017-10-23 06:33:24 UTC

* Missing BuildRequires: gcc
* Build is not verbose
* Group tag is not needed
* %{_libdir}/pkgconfig/ell.pc should be in -devel subpackage
* License is LGPLv2+, not LGPLv2
* Including ChangeLog as %doc would be useful

Comment 2 Lubomir Rintel 2017-10-26 15:47:35 UTC

Thank you. I believe I addressed all the issues.

SRPM: https://copr-be.cloud.fedoraproject.org/results/lkundrak/iwd/fedora-rawhide-x86_64/00654794-libell/libell-0.2-2.fc28.src.rpm
SPEC: https://copr-be.cloud.fedoraproject.org/results/lkundrak/iwd/fedora-rawhide-x86_64/00654794-libell/libell.spec

Comment 3 Gwyn Ciesla 2017-10-27 12:42:21 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libell

Comment 4 Lubomir Rintel 2017-10-29 17:25:02 UTC

Imported and built. Thank you!