Bug 1505327

Summary:	Review Request: rust-void - Uninhabited void type for use in statically impossible cases
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-10-23 14:56:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Igor Gnatenko 2017-10-23 10:54:35 UTC

Spec URL: http://ignatenkobrain.fedorapeople.org//rust-void.spec
SRPM URL: http://ignatenkobrain.fedorapeople.org//rust-void-1.0.2-2.fc28.src.rpm

Description:
Uninhabited void type for use in statically impossible cases.

Comment 1 Igor Gnatenko 2017-10-23 10:55:49 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-void.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-void-1.0.2-2.fc28.src.rpm

FAS username: ignatenkobrain

Comment 2 Robert-André Mauchin 🐧 2017-10-23 11:37:59 UTC

One issue: the project seems to have been relicensed under MIT or ASL 2.0. The crates.io page doesn't reflect this but the Github page does:

>Licensed under either of
>
>    Apache License, Version 2.0, (LICENSE-APACHE or http://www.apache.org
>/licenses/LICENSE-2.0)
>    MIT license (LICENSE-MIT or http://opensource.org/licenses/MIT)
>
>at your option

https://github.com/reem/rust-void

Please correct the License field and grab both LICENSE- files from Github master.

Other than this the package is fine and is accepted.

Comment 3 Igor Gnatenko 2017-10-23 11:48:15 UTC

Relicense happened after releasing 1.0.2, so license is correct.

Comment 4 Robert-André Mauchin 🐧 2017-10-23 12:13:08 UTC

Relicense happened before 1.0.2, see the changelog https://github.com/reem/rust-void/commits/master

Comment 5 Gwyn Ciesla 2017-10-23 12:39:07 UTC

(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-void

Comment 6 Igor Gnatenko 2017-10-23 13:21:21 UTC

(In reply to Robert-André Mauchin from comment #4)
> Relicense happened before 1.0.2, see the changelog
> https://github.com/reem/rust-void/commits/master

Commit happened before, but it got merged only after ;) That's how git-merge --no-ff works ;)