Bug 150538
Summary: | Have to #undef read to build gnome-vfs2 with gcc 4 | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Zeuthen <davidz> | ||||
Component: | gnome-vfs2 | Assignee: | David Zeuthen <davidz> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | alexl, dmalcolm, mclasen | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-04-28 15:07:27 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 136451 | ||||||
Attachments: |
|
Description
David Zeuthen
2005-03-08 02:33:25 UTC
Created attachment 111767 [details]
Patch to make gnome-vfs2 build with gcc 4.0
This is gnome-vfs2 bug. And FYI, it does have nothing to do with GCC 4.0. POSIX explicitely allows read etc. to be defined as a function-like macro, so if you want to use read for something else, you need either #undef read (the bad solution) or use return (tm->real_method->read) (tm->real_method, method_handle, buffer, num_bytes, bytes_read_return, context); or return (*tm->real_method->read) (tm->real_method, method_handle, buffer, num_bytes, bytes_read_return, context); The #undef solution is bad, because you suddenly loose buffer overflow protection for read. This is already fixed long time ago. |