Bug 1505495

Summary: [splitstack] Services are not deployed, but overcloud deploy completes with CREATE_COMPLETE
Product: Red Hat OpenStack Reporter: Gurenko Alex <agurenko>
Component: openstack-tripleo-heat-templatesAssignee: Steve Baker <sbaker>
Status: CLOSED DUPLICATE QA Contact: Gurenko Alex <agurenko>
Severity: high Docs Contact:
Priority: high    
Version: 12.0 (Pike)CC: emacchi, mburns, michele, ohochman, rhel-osp-director-maint, sbaker
Target Milestone: ga   
Target Release: 12.0 (Pike)   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-10-27 13:59:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Messages from controller-0, compute-0, undercloud-0 none

Description Gurenko Alex 2017-10-23 17:09:37 UTC
Created attachment 1342328 [details]
Messages from controller-0, compute-0, undercloud-0

Description of problem: After split stack deployment of 1 compute, 1 controller that completed with CREATE_COMPLETE, but actually no services are installed on the overcloud nodes, including docker


Version-Release number of selected component (if applicable): build 2017-10-17.2


How reproducible:


Steps to Reproduce:

source ~/stackrc && openstack overcloud deploy --templates \
--disable-validation \
--libvirt-type kvm \
-r deployed-server-role-data.yaml \
-e  /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml \
-e  /usr/share/openstack-tripleo-heat-templates/environments/docker-ha.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker-network.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/deployed-server-environment.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/deployed-server-bootstrap-environment-rhel.yaml \
-e /home/stack/virt/docker-images.yaml \
-e /home/stack/virt/debug.yaml \
-e /home/stack/nodes.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e net-static.yaml 2>&1 | tee overcloud_deploy_splitstack_containers.log

Actual results: CREATE_COMPLETE


Expected results: Going through the logs on the overcloud nodes, deployment should've failed on the missing docker service.


Additional info:
Logs are attached (messages from Compute, Controller and from undercloud-0)

Comment 1 Steve Baker 2017-10-25 21:25:47 UTC
In messages-controller-0.log I see

Oct 23 14:53:52 controller-0 os-collect-config: [2017-10-23 14:53:52,197] (heat-config) [INFO] {"deploy_stdout": "\nPLAY [localhost] ***************************************************************\n\nTASK [Gathering Facts] *********************************************************\nok: [localhost]\n\nTASK [Write the config_step hieradata] *****************************************\nchanged: [localhost]\n\nTASK [Run puppet host configuration for step 1] ********************************\nok: [localhost]\n\nTASK [debug] *******************************************************************\nok: [localhost] => {\n    \"(outputs.stderr|default('')).split('\\n')|union(outputs.stdout_lines|default([]))\": [\n        \"Error: Evaluation Error: Error while evaluating a Function Call, Could not find class ::tripleo::profile::base::docker for controller-0.redhat.local at /var/lib/tripleo-config/puppet_step_config.pp:1:1 on node controller-0.redhat.local\"\n    ], \n    \"failed_when_result\": false\n}\

I think this is caused by docker-puppet.py not properly handling error exit codes. I'll attach the upstream issue/fix.

Comment 4 Omri Hochman 2017-10-27 13:59:51 UTC
Closing on duplicate - 1505424

*** This bug has been marked as a duplicate of bug 1505424 ***