Bug 1505885

Summary: vdo --blockMapPeriod accepts values outside bound <1, 16380> and sets them to bounds
Product: Red Hat Enterprise Linux 7 Reporter: Jakub Krysl <jkrysl>
Component: vdoAssignee: bjohnsto
Status: CLOSED ERRATA QA Contact: Jakub Krysl <jkrysl>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.5CC: awalsh, bjohnsto, dkeefe, limershe
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 15:46:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jakub Krysl 2017-10-24 13:29:57 UTC
Description of problem:
When creating VDO with specified --blockMapPeriod out of limits specified in manpage/help ("A  value  between 1 and 16380..."), there is no error and the period is set to closest bound.

# vdo create --device /dev/sdc --name vdo --blockMapPeriod 0                 
Creating VDO vdo                                    
Starting VDO vdo                                    
Starting compression on VDO vdo                     
VDO instance 335 volume is ready at /dev/mapper/vdo 
VDO volume created at /dev/mapper/vdo               
# vdo status --all | grep period                                                                                                                                                           
    Block map period: 1

# vdo create --device /dev/sdc --name vdo --blockMapPeriod 16381                 
Creating VDO vdo                                    
Starting VDO vdo                                    
Starting compression on VDO vdo                     
VDO instance 335 volume is ready at /dev/mapper/vdo 
VDO volume created at /dev/mapper/vdo               
# vdo status --all | grep period                                                                                                                                                           
    Block map period: 16380 

Version-Release number of selected component (if applicable):
vdo-6.1.0.0-6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.vdo create --device /dev/sdc --name vdo --blockMapPeriod not(<1,16380>) 

Actual results:
vdo created with block map period on closest bound

Expected results:
warn/error value out of bounds

Additional info:

Comment 2 bjohnsto 2017-11-17 21:33:47 UTC
Fixed as of vdo version 55

Comment 4 Jakub Krysl 2017-11-21 11:53:50 UTC
vdo 6.1.0.55-10

# vdo create --device /dev/sdc --name vdo --blockMapPeriod 0                        
Usage: vdo --name=<volume>|--all [<option>...] activate|deactivate|create|remove|                        
                                  start|stop|status|list|modify|                                         
                                  changeWritePolicy|enableDeduplication|                                 
                                  disableDeduplication|enableCompression|                                
                                  disableCompression|growLogical|growPhysical|                           
                                  printConfigFile   

vdo: error: option --blockMapPeriod: must be an integer at least 1 and less than or equal to 16380       
    
# vdo create --device /dev/sdc --name vdo --blockMapPeriod 16381                    
Usage: vdo --name=<volume>|--all [<option>...] activate|deactivate|create|remove|                        
                                  start|stop|status|list|modify|                                         
                                  changeWritePolicy|enableDeduplication|                                 
                                  disableDeduplication|enableCompression|                                
                                  disableCompression|growLogical|growPhysical|                           
                                  printConfigFile
vdo: error: option --blockMapPeriod: must be an integer at least 1 and less than or equal to 16380

Comment 7 errata-xmlrpc 2018-04-10 15:46:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2018:0871