Bug 1506425

Summary:	Improve valueset sort performance during valueset purging
Product:	Red Hat Enterprise Linux 7	Reporter:	mreynolds
Component:	389-ds-base	Assignee:	mreynolds
Status:	CLOSED ERRATA	QA Contact:	Viktor Ashirov <vashirov>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	7.5	CC:	msauton, nkinder, rmeggins
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	389-ds-base-1.3.7.5-7.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1506912 (view as bug list)		Environment:
Last Closed:	2018-04-10 14:21:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1506912

Description mreynolds 2017-10-26 02:14:16 UTC

Description of problem:

valueset sorted maintains a list of syntax sorted references to the attributes of the entry. During addition these are modified and added properly, so they stay sorted.

However, in the past to maintain the sorted property, during a delete we would need to remove the vs->sorted array, and recreate it via qsort,

While this was an improvement from past (where we would removed vs->sorted during an attr delete), it still has performance implications on very very large datasets, IE 50,000 member groups with addition/deletion, large entry caches and replication.

This performance can be improved through a better management of deletion events in the valueset api.
Version-Release number of selected component (if applicable):

Comment 2 mreynolds 2017-10-26 02:15:37 UTC

Upstream ticket:

https://pagure.io/389-ds-base/issue/49401

Comment 5 Viktor Ashirov 2017-11-20 15:49:02 UTC

The problem in the original bug occurs in a very specific environment, which we can't reproduce.

Acceptance tests and replication tests pass with this fix.

Marking as VERIFIED, SanityOnly.

Comment 8 errata-xmlrpc 2018-04-10 14:21:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0811