Bug 1506428
Summary: | Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Audrey Yeena Toskin <audrey> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | package-review, rdieter, troy, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | noarch | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-02-13 17:37:37 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Audrey Yeena Toskin
2017-10-26 02:49:03 UTC
Oops, the *new* package name will be gnome-shell-extension-historymanager-prefix-search (without "sustmi" in the middle). - Please edit the bug title to follow the pattern for RR: Review Request: gnome-shell-extension-historymanager-prefix-search - Use PageUp and PageDown to search for previous GNOME Shell commands Otherwise you won't pe able to use fedrepo-req when the puckage is accepted. Since this package does not have any schemas, probably do not need the BuildRequires on glib for CentOS/RHEL 7. According to my repoquery, nothing currently depends on 'gnome-shell-extension-sustmi-historymanager-prefix-search', so I don't think you need the Provides line for the old name. Oh, yeah, that BuildRequires tag was leftover from when this was one of two subpackages; the other did have schemas, this one does not. I guess I read the The "Upgrade Paths" Fedora wiki page too quickly. Anything depending on these recently added GNOME Shelle extensions seems pretty unlikely, so yeah, I guess the Provides tag was also unnecessary. I've removed both the BuildRequires and Provides tags. Same URLs. Hello again Andrew, - Please use a more meaningful name for your archive, with: Source0: https://github.com/sustmi/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz Package is fine otherwise, it is accepted. > Please use a more meaningful name for your archive Done. Spec URL: https://gitlab.com/terrycloth/packaging-gnome-shell-extension-historymanager-prefix-search/raw/master/gnome-shell-extension-historymanager-prefix-search.spec SRPM URL: https://andrew.tosk.in/tmp/gnome-shell-extension-historymanager-prefix-search-10-2.fc28.src.rpm I'm not positive about this part of the process, but I've also opened an issue on RelEng's Pagure about splitting the packages. https://pagure.io/releng/issue/7124 Is there anything else I need to do before the newly split package can be accepted...? Next steps (for submitter/maintainer): https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner THANK YOU. That step was not mentioned in the wiki page about splitting packages, and it didn't occur to me to treat the newly split packages so much like creating whole new packages from scratch. However, now I have a new problem: fedrepo-req reports "Error: The Bugzilla bug's review was approved over 60 days ago" Rex, could you maybe mark this as approved again? Along with the other split package, in Bug #1506429? Or do I have to start over with a new review request, even though the packages haven't changed since October? Rex is probably very busy Cool, thanks! (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-historymanager-prefix-search gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-b866dfc687 gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a458392fef gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a458392fef gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-b866dfc687 gnome-shell-extension-historymanager-prefix-search-10-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. gnome-shell-extension-historymanager-prefix-search-10-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. |