Bug 1506713

Summary:	Update parameter types are not properly passed out on the /v2/catalog API
Product:	OpenShift Container Platform	Reporter:	Jason Montleon <jmontleo>
Component:	Service Broker	Assignee:	Jason Montleon <jmontleo>
Status:	CLOSED ERRATA	QA Contact:	Weihua Meng <wmeng>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.0	CC:	aos-bugs, jmontleo, qixuan.wang, wmeng
Target Milestone:	---
Target Release:	3.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-11-28 22:19:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jason Montleon 2017-10-26 15:42:39 UTC

Description of problem:
Update parameters are all appearing as strings

Version-Release number of selected component (if applicable):
ansible-service-broker-1.0.11-1

How reproducible:
Always

Steps to Reproduce:
1. Run catasb and install OCP
2. curl -k -XGET -H "Authorization: Bearer $(oc whoami -t)" -H 'Content-Type: application/json'  https://asb-1338-ansible-service-broker.172.18.0.1.nip.io/ansible-service-broker/v2/catalog

Actual results:
Type for all update params appears as strings

Expected results:
Types are set correctly

Additional info:

Comment 1 Jason Montleon 2017-10-26 15:44:49 UTC

https://github.com/openshift/ansible-service-broker/pull/517

Comment 4 Weihua Meng 2017-10-31 07:58:23 UTC

Not in latest image openshift3/ose-ansible-service-broker/images/v3.7.0-0.185.0.0
will check it later.

              "update": {
                "parameters": {
                  "$schema": "http://json-schema.org/draft-04/schema",
                  "additionalProperties": false,
                  "properties": {
                    "postgresql_version": {
                      "default": "9.5",
                      "title": "PostgreSQL Version",
                      "type": "string"
                    }
                  },
                  "required": [
                    "postgresql_version"
                  ],
                  "type": "object"
                }
              }

Comment 5 Jason Montleon 2017-11-02 12:40:06 UTC

Can you recheck this with v3.7.0-0.189.0.0?

Comment 6 Weihua Meng 2017-11-02 12:52:16 UTC

Not in ansible-service-broker-1.0.13-1.el7.x86_64
openshift3/ose-ansible-service-broker:v3.7.0-0.189.0.0

              "update": {
                "parameters": {
                  "$schema": "http://json-schema.org/draft-04/schema",
                  "additionalProperties": false,
                  "properties": {
                    "postgresql_version": {
                      "default": "9.5",
                      "enum": [
                        "9.5",
                        "9.4"
                      ],
                      "title": "PostgreSQL Version",
                      "type": "string"
                    }
                  },
                  "required": [
                    "postgresql_version"
                  ],
                  "type": "object"
                }
              }

Comment 7 Weihua Meng 2017-11-02 12:54:13 UTC

                      "enum": [
                        "9.5",
                        "9.4"
                      ],
means it is fixed, right?

Comment 8 Jason Montleon 2017-11-02 13:04:14 UTC

Correct

Comment 9 Weihua Meng 2017-11-02 13:10:37 UTC

Fixed in ansible-service-broker-1.0.13-1.el7.x86_64
openshift3/ose-ansible-service-broker:v3.7.0-0.189.0.0

Thanks, Jason

Comment 12 errata-xmlrpc 2017-11-28 22:19:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2017:3188