Bug 1506734 (php-amqplib)

Summary: Review Request: php-amqplib - Pure PHP implementation of the AMQP protocol
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, package-review
Target Milestone: ---Flags: fedora: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-14 00:55:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1483285    
Attachments:
Description Flags
phpci.log
none
review.txt
none
review.txt none

Description Shawn Iwinski 2017-10-26 16:58:30 UTC 
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/484408c7c258c8cf68ee8b584327045fb5def39e/php-amqplib/php-amqplib.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-amqplib-2.7.0-1.fc26.src.rpm

Description:
This library is a pure PHP implementation of the AMQP 0-9-1 protocol. It's
been tested against RabbitMQ.


Fedora Account System Username: siwinski
Comment 1 Remi Collet 2017-10-29 07:28:37 UTC 
Mirnor issue with local build

1) PhpAmqpLib\Tests\Unit\AMQPCollectionTest::testEncode080
Failed asserting that two arrays are equal.

Trivial fix, in tests bootstrap
date_default_timezone_set('UTC');

BTW, test suite passes, so not a blocker (mock), but "nice to have".
Comment 2 Remi Collet 2017-10-29 07:33:37 UTC 
Created attachment 1344953 [details]
phpci.log

phpCompatInfo version 5.0.8 DB version 1.24.0 built Oct 03 2017
     06:26:53 CEST static analyze results
Comment 3 Remi Collet 2017-10-29 07:34:15 UTC 
Created attachment 1344954 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1506734
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Comment 4 Remi Collet 2017-10-29 07:34:45 UTC 
Created attachment 1344955 [details]
review.txt

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1506734
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, PHP, Shell-api
Comment 5 Remi Collet 2017-10-29 07:35:45 UTC 
[x]: Package complies to the Packaging Guidelines


=== APPROVED ====
Comment 6 Shawn Iwinski 2017-11-02 04:25:46 UTC 
THANKS for the review!

https://pagure.io/releng/fedora-scm-requests/issue/2576
https://pagure.io/releng/fedora-scm-requests/issue/2577
https://pagure.io/releng/fedora-scm-requests/issue/2578
https://pagure.io/releng/fedora-scm-requests/issue/2579
https://pagure.io/releng/fedora-scm-requests/issue/2580
https://pagure.io/releng/fedora-scm-requests/issue/2581



(In reply to Remi Collet from comment #1)
> Mirnor issue with local build
> 
> 1) PhpAmqpLib\Tests\Unit\AMQPCollectionTest::testEncode080
> Failed asserting that two arrays are equal.
> 
> Trivial fix, in tests bootstrap
> date_default_timezone_set('UTC');
> 
> BTW, test suite passes, so not a blocker (mock), but "nice to have".

I'll add this after initial import.
Comment 7 Gwyn Ciesla 2017-11-02 12:57:34 UTC 
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-amqplib
Comment 8 Fedora Update System 2017-11-03 22:06:57 UTC 
php-amqplib-2.7.0-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ee46690069
Comment 9 Fedora Update System 2017-11-03 22:07:05 UTC 
php-amqplib-2.7.0-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-73a12da597
Comment 10 Fedora Update System 2017-11-03 22:07:10 UTC 
php-amqplib-2.7.0-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-e55a4b2d86
Comment 11 Fedora Update System 2017-11-03 22:07:16 UTC 
php-amqplib-2.7.0-2.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-febfdd0592
Comment 12 Fedora Update System 2017-11-03 22:07:22 UTC 
php-amqplib-2.7.0-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f4924552c1
Comment 13 Fedora Update System 2017-11-04 19:06:36 UTC 
php-amqplib-2.7.0-2.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-febfdd0592
Comment 14 Fedora Update System 2017-11-04 19:28:03 UTC 
php-amqplib-2.7.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-f4924552c1
Comment 15 Fedora Update System 2017-11-04 19:28:06 UTC 
php-amqplib-2.7.0-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-ee46690069
Comment 16 Fedora Update System 2017-11-04 19:58:21 UTC 
php-amqplib-2.7.0-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-e55a4b2d86
Comment 17 Fedora Update System 2017-11-04 22:21:58 UTC 
php-amqplib-2.7.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-73a12da597
Comment 18 Fedora Update System 2017-11-14 00:55:17 UTC 
php-amqplib-2.7.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Comment 19 Fedora Update System 2017-11-14 01:59:38 UTC 
php-amqplib-2.7.0-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2017-11-14 08:50:39 UTC 
php-amqplib-2.7.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
Comment 21 Fedora Update System 2017-11-14 09:23:17 UTC 
php-amqplib-2.7.0-2.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report.
Comment 22 Fedora Update System 2017-11-25 04:11:41 UTC 
php-amqplib-2.7.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
Comment 23 Fedora Update System 2017-11-25 05:14:05 UTC 
php-amqplib-2.7.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.