Bug 1507086

Summary: Review Request: rust-yubibomb - Rust command line tool that prints out a 6-digit random number
Product: [Fedora] Fedora Reporter: Igor Gnatenko <ignatenko>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review, randy
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-11-03 21:29:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1507082    
Bug Blocks:    

Description Igor Gnatenko 2017-10-27 16:01:49 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-yubibomb.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/rust-yubibomb-0.1.0-1.fc28.src.rpm
Description:
Rust command line tool that prints out a 6-digit random number.
Fedora Account System Username: ignatenkobrain

Comment 1 Neal Gompa 2017-10-27 16:02:21 UTC
Taking this review.

Comment 2 Neal Gompa 2017-10-27 16:12:49 UTC
Package was generated through rust2rpm, simplifying the review considerably.

- Conforms to packaging guidelines (rust2rpm generated spec)
- license correct and valid
- as this is a CLI crate that provides no API, it installs binaries correctly

PACKAGE APPROVED.

Comment 3 Gwyn Ciesla 2017-10-27 16:24:06 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-yubibomb

Comment 4 Randy Barlow 2017-11-03 21:36:27 UTC
+1